Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots #2700

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 9, 2024

Backport 8280982


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280982 needs maintainer approval
  • Change requires CSR request JDK-8335485 to be approved

Issues

  • JDK-8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots (Bug - P3 - Approved)
  • JDK-8335485: [Wayland] [XWayland] java.awt.Robot taking screenshots (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2700/head:pull/2700
$ git checkout pull/2700

Update a local copy of the PR:
$ git checkout pull/2700
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2700/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2700

View PR using the GUI difftool:
$ git pr show -t 2700

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2700.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 9, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e809008: 8300910: Remove metaprogramming/integralConstant.hpp
  • 952d272: 8300265: Remove metaprogramming/isSigned.hpp
  • f9acc53: 8300260: Remove metaprogramming/isSame.hpp
  • 3069e3e: 8305959: x86: Improve itable_stub

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 9d7bf5329e5a0393553bca2e3a51ad1125b41b96 8280982: [Wayland] [XWayland] java.awt.Robot taking screenshots Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 9, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Jul 9, 2024

src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c needs a bit of manual change integration; otherwise the backport is clean and is recognized as clean by the tooling.

@mlbridge
Copy link

mlbridge bot commented Jul 9, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 10, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

Going to push as commit c915eaf.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 3d83f3e: 8329109: Threads::print_on() tries to print CPU time for terminated GC threads
  • 1e63af9: 8300806: Update googletest to v1.13.0
  • e809008: 8300910: Remove metaprogramming/integralConstant.hpp
  • 952d272: 8300265: Remove metaprogramming/isSigned.hpp
  • f9acc53: 8300260: Remove metaprogramming/isSame.hpp
  • 3069e3e: 8305959: x86: Improve itable_stub

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2024
@openjdk openjdk bot closed this Jul 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@MBaesken Pushed as commit c915eaf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant