-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file #2702
8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file #2702
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Trivial typo fix in a test that was spotted in backporting 8299635 to 17u. Makes sense to fix it everywhere. Test failure looks unrelated (timeout) |
@gnu-andrew |
I see |
Going to push as commit 72de151.
Your commit was automatically rebased without conflicts. |
@gnu-andrew Pushed as commit 72de151. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
A trivial backport to fix a typo (an errant 's') in test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/functions/rawmonitor/rawmonitor.cpp introduced by JDK-8299635. This is a clean backport from 21u. The original from 24 did not apply cleanly to 21u as it doesn't have JDK-8324681 which bumped the copyright header to 2024 (which probably should have been bumped to 2023 in 8299635!)
This was spotted by George Adams (@gdams) when backporting 8299635 to 17u, where it is now needed to support builds on newer versions of Mac OS. It's a trivial fix it makes sense to clean up everywhere.
The original commit being backported was authored by Severin Gehwolf on 5 Jul 2024 and was reviewed by George Adams and Thomas Stuefe. It has been backported to 21u & 23.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2702/head:pull/2702
$ git checkout pull/2702
Update a local copy of the PR:
$ git checkout pull/2702
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2702/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2702
View PR using the GUI difftool:
$ git pr show -t 2702
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2702.diff
Webrev
Link to Webrev Comment