Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." #2709

Closed
wants to merge 1 commit into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jul 12, 2024

I backport this for parity with 17.0.13-oracle.


Progress

  • JDK-8272232 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8257540 needs maintainer approval

Issues

  • JDK-8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." (Bug - P4 - Approved)
  • JDK-8257540: javax/swing/JFileChooser/8041694/bug8041694.java failed with "RuntimeException: The selected directory name is not the expected 'd ' but 'D '." (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2709/head:pull/2709
$ git checkout pull/2709

Update a local copy of the PR:
$ git checkout pull/2709
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2709

View PR using the GUI difftool:
$ git pr show -t 2709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2709.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 12, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'."
8257540: javax/swing/JFileChooser/8041694/bug8041694.java failed with "RuntimeException: The selected directory name is not the expected 'd ' but 'D '."

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • 97be07a: 8307779: Relax the java.awt.Robot specification
  • 14e3de9: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 385952c: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • 1f0ec1d: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • 00b764c: 8299058: AssertionError in sun.net.httpserver.ServerImpl when connection is idle
  • 07be2e5: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow
  • 2464d8c: 8285497: Add system property for Java SE specification maintenance version
  • 6a31071: Merge
  • 833f65e: 8335963: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.12
  • cac9bbe: 8320548: Improved loop handling
  • ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/05bea0e5377a1f21b045049591cba106ff2210b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cec6c068b03d890312e50b448fbc26102c635249 8272232: javax/swing/JTable/4275046/bug4275046.java failed with "Expected value in the cell: 'rededited' but found 'redEDITED'." Jul 12, 2024
@openjdk
Copy link

openjdk bot commented Jul 12, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 12, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 12, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 12, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 15, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2024

Going to push as commit 0644986.
Since your change was applied there have been 31 commits pushed to the master branch:

  • 9e14667: 8332424: Update IANA Language Subtag Registry to Version 2024-05-16
  • 97be07a: 8307779: Relax the java.awt.Robot specification
  • 14e3de9: 8319103: Popups that request focus are not shown on Linux with Wayland
  • 385952c: 8328273: sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java failed with java.rmi.server.ExportException: Port already in use
  • 1f0ec1d: 8317316: G1: Make TestG1PercentageOptions use createTestJvm
  • 00b764c: 8299058: AssertionError in sun.net.httpserver.ServerImpl when connection is idle
  • 07be2e5: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow
  • 2464d8c: 8285497: Add system property for Java SE specification maintenance version
  • 6a31071: Merge
  • 833f65e: 8335963: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.12
  • ... and 21 more: https://git.openjdk.org/jdk17u-dev/compare/05bea0e5377a1f21b045049591cba106ff2210b2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2024
@openjdk openjdk bot closed this Jul 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2024
@openjdk
Copy link

openjdk bot commented Jul 19, 2024

@luchenlin Pushed as commit 0644986.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant