Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message #2720

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 16, 2024

Hi all,

This pull request contains a backport of commit c798316b from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 28 Jun 2024 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8269657 needs maintainer approval

Issue

  • JDK-8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2720/head:pull/2720
$ git checkout pull/2720

Update a local copy of the PR:
$ git checkout pull/2720
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2720

View PR using the GUI difftool:
$ git pr show -t 2720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2720.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • efee05f: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
  • 5ed58c2: 8326332: Unclosed inline tags cause misalignment in summary tables
  • 2b9228a: 8318696: Do not use LFS64 symbols on Linux
  • 77cb961: 8323122: AArch64: Increase itable stub size estimate
  • fb7bb62: 8310628: GcInfoBuilder.c missing JNI Exception checks
  • 666e489: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
  • c18ddd8: 8321176: [Screencast] make a second attempt on screencast failure
  • fe1a4a8: 8276660: Scalability bottleneck in java.security.Provider.getService()
  • 9ef505d: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 269bd25: 8307352: AARCH64: Improve itable_stub
  • ... and 36 more: https://git.openjdk.org/jdk17u-dev/compare/a1e7701e47accca545016839c388f7130d7d81b4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c798316bc4cb33fd902f926030d8a0b6870d661a 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message Jul 16, 2024
@openjdk
Copy link

openjdk bot commented Jul 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 16, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the testcase bug and solve the intermittent failure, no risk.

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@sendaoYan
8269657: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 17, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jul 29, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approval.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@sendaoYan
Your change (at version 0f6e52c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Aug 1, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

Going to push as commit 772c978.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 6819381: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • a15f35d: 8298381: Improve handling of session tickets for multiple SSLContexts
  • c32a56f: 8331077: nroff man page update for jar tool
  • f4e8194: 8324753: [AIX] adjust os_posix after JDK-8318696
  • efee05f: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
  • 5ed58c2: 8326332: Unclosed inline tags cause misalignment in summary tables
  • 2b9228a: 8318696: Do not use LFS64 symbols on Linux
  • 77cb961: 8323122: AArch64: Increase itable stub size estimate
  • ... and 42 more: https://git.openjdk.org/jdk17u-dev/compare/a1e7701e47accca545016839c388f7130d7d81b4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2024
@openjdk openjdk bot closed this Aug 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

@shipilev @sendaoYan Pushed as commit 772c978.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants