Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm #2724

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Jul 18, 2024

I backport this for parity with 17.0.13-oracle.
String.splitWithDelimiters not support in jdk17


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317228 needs maintainer approval

Issue

  • JDK-8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2724/head:pull/2724
$ git checkout pull/2724

Update a local copy of the PR:
$ git checkout pull/2724
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2724

View PR using the GUI difftool:
$ git pr show -t 2724

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2724.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • fe1a4a8: 8276660: Scalability bottleneck in java.security.Provider.getService()
  • 9ef505d: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 269bd25: 8307352: AARCH64: Improve itable_stub
  • c7ca5f8: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
  • 933587a: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
  • 234bf86: 8331011: [XWayland] TokenStorage fails under Security Manager
  • 3d39e85: 8320655: awt screencast robot spin and sync issues with native libpipewire api
  • 73b24d0: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
  • e0e2fe6: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
  • 6e3dca8: 8280034: ProblemList jdk/jfr/api/consumer/recordingstream/TestOnEvent.java on linux-x64
  • ... and 31 more: https://git.openjdk.org/jdk17u-dev/compare/5d6d176210a60603b65522616d2d2f6279b3412f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7ca0ae94159ac0fd2df23ee1a1e8cf626ce31048 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm Jul 18, 2024
@openjdk
Copy link

openjdk bot commented Jul 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jul 18, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 25, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 26, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

Going to push as commit 666e489.
Since your change was applied there have been 42 commits pushed to the master branch:

  • c18ddd8: 8321176: [Screencast] make a second attempt on screencast failure
  • fe1a4a8: 8276660: Scalability bottleneck in java.security.Provider.getService()
  • 9ef505d: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 269bd25: 8307352: AARCH64: Improve itable_stub
  • c7ca5f8: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
  • 933587a: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
  • 234bf86: 8331011: [XWayland] TokenStorage fails under Security Manager
  • 3d39e85: 8320655: awt screencast robot spin and sync issues with native libpipewire api
  • 73b24d0: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC
  • e0e2fe6: 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java
  • ... and 32 more: https://git.openjdk.org/jdk17u-dev/compare/5d6d176210a60603b65522616d2d2f6279b3412f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2024
@openjdk openjdk bot closed this Jul 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2024
@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@luchenlin Pushed as commit 666e489.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants