8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

[synecdoche]

Clean backport. Fixes spacing mark detection in java.util.regex for code points 0x1065 and 0x1066.

Additional testing:

• test case catches original bug; fails without it
• JTREG_KEYWORDS="\!headful & \!external-dep & \!printer" make test TEST="tier1 tier2 tier3" on linux-aarch64-server-release: no additional test failures

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8273430 needs maintainer approval

Issue

• JDK-8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2731/head:pull/2731
$ git checkout pull/2731

Update a local copy of the PR:
$ git checkout pull/2731
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2731/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2731

View PR using the GUI difftool:
$ git pr show -t 2731

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2731.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back synecdoche! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@synecdoche This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273430: Suspicious duplicate condition in java.util.regex.Grapheme#isExcludedSpacingMark

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e49367b: 8297878: KEM: Implementation
• 1219484: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
• 6e93acc: 8301200: Don't scale timeout stress with timeout factor
• aa75196: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @synecdoche This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (cce740ef)

[synecdoche]

/approval request Clean backport. Fixes spacing mark detection in java.util.regex for code points 0x1065 and 0x1066. It has been soaking upstream for a few years. Affects grapheme boundary detection.

[openjdk]

@synecdoche
8273430: The approval request has been created successfully.

[Rudometov]

/sponsor

[openjdk]

@Rudometov The change author (@synecdoche) must issue an integrate command before the integration can be sponsored.

[synecdoche]

/integrate

[openjdk]

@synecdoche
Your change (at version cce740e) is now ready to be sponsored by a Committer.

[Rudometov]

/sponsor

[openjdk]

Going to push as commit 0bc3783.
Since your change was applied there have been 4 commits pushed to the master branch:

• e49367b: 8297878: KEM: Implementation
• 1219484: 8309621: [XWayland][Screencast] screen capture failure with sun.java2d.uiScale other than 1
• 6e93acc: 8301200: Don't scale timeout stress with timeout factor
• aa75196: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14

Your commit was automatically rebased without conflicts.

[openjdk]

@Rudometov @synecdoche Pushed as commit 0bc3783.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.