-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3 #2736
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
@sendaoYan |
This backport has been verified, no risk. |
This test should set as |
This test should set as /native, which I have create a jbs JDK-8337038 to record this issue. |
@sendaoYan |
Thanks all for the review and approved. |
@sendaoYan |
/sponsor |
Going to push as commit c7ca5f8.
Your commit was automatically rebased without conflicts. |
@phohensee @sendaoYan Pushed as commit c7ca5f8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
This pull request contains a backport of commit 7baddc20 from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 23 Jun 2024 and was reviewed by Alan Bateman.
This backport not clean because it's diffrent context.
This backport has been verified, no risk.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2736/head:pull/2736
$ git checkout pull/2736
Update a local copy of the PR:
$ git checkout pull/2736
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2736/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2736
View PR using the GUI difftool:
$ git pr show -t 2736
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2736.diff
Webrev
Link to Webrev Comment