Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly #274

Closed
wants to merge 1 commit into from

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Mar 21, 2022

Hi

This pull request contains a backport of openjdk/jdk@0cbc4b8.

The patch introduces a fix and a new test for the bug being fixed. The test fails against jdk17u-dev master prior to the patch and passes afterwards.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/274/head:pull/274
$ git checkout pull/274

Update a local copy of the PR:
$ git checkout pull/274
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/274/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 274

View PR using the GUI difftool:
$ git pr show -t 274

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/274.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2022

👋 Welcome back zakkak! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0cbc4b85bf8ab2ccfb8762322098c4cc7996df7d 8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

⚠️ @zakkak the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout fix-mandrel-355-v3
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@zakkak This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281266: [JVMCI] MetaUtil.toInternalName() doesn't handle hidden classes correctly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Mar 21, 2022
@zakkak
Copy link
Contributor Author

zakkak commented Mar 21, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@zakkak
Your change (at version 17cad3e) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Mar 21, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Mar 21, 2022

@zakkak Please only /integrate once you've got push approval as per: https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u ("Fix Approvals" section). Thanks!

@zakkak
Copy link
Contributor Author

zakkak commented Mar 21, 2022

@zakkak Please only /integrate once you've got push approval as per: https://wiki.openjdk.java.net/display/JDKUpdates/JDK+17u ("Fix Approvals" section). Thanks!

OK, I was following the bot's comment:

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@jerboaa
Copy link
Contributor

jerboaa commented Mar 21, 2022

OK, I was following the bot's comment:

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.
arrow_right To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Hopefully https://bugs.openjdk.java.net/browse/SKARA-1199 will improve this situation :)

@jerboaa
Copy link
Contributor

jerboaa commented Mar 23, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit 13140f9.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 1705541: 8281338: NSAccessibilityPressAction action for tree node and NSAccessibilityShowMenuAcgtion action not working
  • d62a116: Merge
  • c3ea7ca: 8282761: XPathFactoryImpl remove setProperty and getProperty methods
  • 18ece9b: 8282345: handle latest VS2022 in abstract_vm_version
  • d442446: 8281274: deal with ActiveProcessorCount in os::Linux::print_container_info
  • d6eb281: 8280543: Update the "java" and "jcmd" tool specification for CDS
  • d19ec6f: 8193682: Infinite loop in ZipOutputStream.close()
  • 937b55c: 8282583: Update BCEL md to include the copyright notice
  • a7efcca: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
  • 9bfb322: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
  • ... and 6 more: https://git.openjdk.java.net/jdk17u-dev/compare/049b1baaf5d8535a59b5e2d96317560f2c83ae41...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@jerboaa @zakkak Pushed as commit 13140f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@zakkak zakkak deleted the fix-mandrel-355-v3 branch Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants