8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator

[shipilev]

Semi-clean backport to sync up code bases and make the future backports clean. The change should have no material effect, since it just moves code around. The conflicts are in copyright years, and there is a separate place in ShenandoahNMethodPurgeTask that is not in mainline since Sweeper removal.

Additional testing:

• Linux AArch64 server fastdebug, hotspot_gc_shenandoah
• Linux AArch64 server fastdebug, tier1 with -XX:+UseShenandoahGC

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8334769 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator (Enhancement - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2742/head:pull/2742
$ git checkout pull/2742

Update a local copy of the PR:
$ git checkout pull/2742
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2742

View PR using the GUI difftool:
$ git pr show -t 2742

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2742.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• fe1a4a8: 8276660: Scalability bottleneck in java.security.Provider.getService()
• 9ef505d: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• 269bd25: 8307352: AARCH64: Improve itable_stub
• c7ca5f8: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• 933587a: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
• 234bf86: 8331011: [XWayland] TokenStorage fails under Security Manager
• 3d39e85: 8320655: awt screencast robot spin and sync issues with native libpipewire api
• 73b24d0: 8327424: ProblemList serviceability/sa/TestJmapCore.java on all platforms with ZGC

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (fc7931df)
• 00: Full (b769f761)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval Unclean backport to sync up code bases and make the future backports clean. Risk is low: the change just moves code around. Testing passes. PR is reviewed by Paul Hohensee.

[openjdk]

@shipilev usage: /approval [<id>] (request|cancel) [<text>]

[shipilev]

/approval request Unclean backport to sync up code bases and make the future backports clean. Risk is low: the change just moves code around. Testing passes. PR is reviewed by Paul Hohensee.

[openjdk]

@shipilev
8334769: The approval request has been created successfully.

[shipilev]

/integrate

[openjdk]

Going to push as commit efee05f.
Since your change was applied there have been 14 commits pushed to the master branch:

• 5ed58c2: 8326332: Unclosed inline tags cause misalignment in summary tables
• 2b9228a: 8318696: Do not use LFS64 symbols on Linux
• 77cb961: 8323122: AArch64: Increase itable stub size estimate
• fb7bb62: 8310628: GcInfoBuilder.c missing JNI Exception checks
• 666e489: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm
• c18ddd8: 8321176: [Screencast] make a second attempt on screencast failure
• fe1a4a8: 8276660: Scalability bottleneck in java.security.Provider.getService()
• 9ef505d: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• 269bd25: 8307352: AARCH64: Improve itable_stub
• c7ca5f8: 8334339: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java fails on alinux3
• ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/e0e2fe646c6c9fefc2bde8476240589aa3ec149e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit efee05f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.