Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331077: nroff man page update for jar tool #2748

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 29, 2024

Backport of 8331077


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331077 needs maintainer approval

Issue

  • JDK-8331077: nroff man page update for jar tool (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2748/head:pull/2748
$ git checkout pull/2748

Update a local copy of the PR:
$ git checkout pull/2748
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2748/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2748

View PR using the GUI difftool:
$ git pr show -t 2748

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2748.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331077: nroff man page update for jar tool

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • f4e8194: 8324753: [AIX] adjust os_posix after JDK-8318696
  • efee05f: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
  • 5ed58c2: 8326332: Unclosed inline tags cause misalignment in summary tables
  • 2b9228a: 8318696: Do not use LFS64 symbols on Linux

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c21672d8c94da6aa613174744ceaa945ca2a474a 8331077: nroff man page update for jar tool Jul 29, 2024
@openjdk
Copy link

openjdk bot commented Jul 29, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2024

Webrevs

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member Author

Hi Ralf, thanks for the review !

@MBaesken
Copy link
Member Author

/approval

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@MBaesken usage: /approval [<id>] (request|cancel) [<text>]

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 30, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 30, 2024

Going to push as commit c32a56f.
Since your change was applied there have been 4 commits pushed to the master branch:

  • f4e8194: 8324753: [AIX] adjust os_posix after JDK-8318696
  • efee05f: 8334769: Shenandoah: Move CodeCache_lock close to its use in ShenandoahConcurrentNMethodIterator
  • 5ed58c2: 8326332: Unclosed inline tags cause misalignment in summary tables
  • 2b9228a: 8318696: Do not use LFS64 symbols on Linux

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 30, 2024
@openjdk openjdk bot closed this Jul 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 30, 2024
@openjdk
Copy link

openjdk bot commented Jul 30, 2024

@MBaesken Pushed as commit c32a56f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants