Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native #2752

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jul 31, 2024

Hi all,

This pull request contains a backport of commit 2c9f741d from the openjdk/jdk21u-dev repository.

The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337038 needs maintainer approval

Issue

  • JDK-8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2752/head:pull/2752
$ git checkout pull/2752

Update a local copy of the PR:
$ git checkout pull/2752
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2752

View PR using the GUI difftool:
$ git pr show -t 2752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2752.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 2c9f741d9ce27cd81e4ad9395a88af1b34a2ba77 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2024

Webrevs

@sendaoYan
Copy link
Member Author

The GHA report gc/metaspace/TestMetaspacePerfCounters.java#id3 intermittent fails assertGreaterThanOrEqual: expected 655360 >= 879336, I have created a jbs JDK-8337521 to recorded this failure. I think it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport JDK-8337038 to jdk17u-dev, to set the test as /native. Trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@sendaoYan
8337038: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Jul 31, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approval.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@sendaoYan
Your change (at version e395866) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

Going to push as commit 5e0e2e3.
Since your change was applied there have been 37 commits pushed to the master branch:

  • 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
  • 185e69a: 8334166: Enable binary check
  • 9990cfa: 8272558: IR Test Framework README misses some flags
  • 0330069: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
  • 7f78f21: 8316285: Opensource JButton manual tests
  • c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • 971b01a: 8315965: Open source various AWT applet tests
  • 0b789c1: 8332113: Update nsk.share.Log to be always verbose
  • 2e9152d: 8336928: GHA: Bundle artifacts removal broken
  • 4aa7950: 8337283: configure.log is truncated when build dir is on different filesystem
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/c32a56fc69602db954d4bdf0e986037fab6f0951...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2024
@openjdk openjdk bot closed this Aug 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@TheRealMDoerr @sendaoYan Pushed as commit 5e0e2e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

sendaoYan commented Aug 16, 2024

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants