-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native #2752
8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native #2752
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
The GHA report |
/approval request Clean backport JDK-8337038 to jdk17u-dev, to set the test as |
@sendaoYan |
Thanks for the approval. |
@sendaoYan |
/sponsor |
Going to push as commit 5e0e2e3.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @sendaoYan Pushed as commit 5e0e2e3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
This pull request contains a backport of commit 2c9f741d from the openjdk/jdk21u-dev repository.
The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Matthias Baesken.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2752/head:pull/2752
$ git checkout pull/2752
Update a local copy of the PR:
$ git checkout pull/2752
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2752/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2752
View PR using the GUI difftool:
$ git pr show -t 2752
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2752.diff
Webrev
Link to Webrev Comment