-
Notifications
You must be signed in to change notification settings - Fork 224
8292044: HttpClient doesn't handle 102 or 103 properly #2753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8292044: HttpClient doesn't handle 102 or 103 properly #2753
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only context diffs in the import sections of Exchange.java and HttpClientImpl.java. Lgtm.
|
/integrate |
Going to push as commit 1000028.
Your commit was automatically rebased without conflicts. |
Backport of 8292044, src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java and src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java need imports manually added (diffs in the stride) and small test adjustments because of differences in jdk17 compared to higher jdk (imports and library/build statements)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2753/head:pull/2753
$ git checkout pull/2753
Update a local copy of the PR:
$ git checkout pull/2753
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2753/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2753
View PR using the GUI difftool:
$ git pr show -t 2753
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2753.diff
Webrev
Link to Webrev Comment