Skip to content

8292044: HttpClient doesn't handle 102 or 103 properly #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 31, 2024

Backport of 8292044, src/java.net.http/share/classes/jdk/internal/net/http/HttpClientImpl.java and src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java need imports manually added (diffs in the stride) and small test adjustments because of differences in jdk17 compared to higher jdk (imports and library/build statements)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8292044 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8292044: HttpClient doesn't handle 102 or 103 properly (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2753/head:pull/2753
$ git checkout pull/2753

Update a local copy of the PR:
$ git checkout pull/2753
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2753/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2753

View PR using the GUI difftool:
$ git pr show -t 2753

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2753.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292044: HttpClient doesn't handle 102 or 103 properly

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 772c978: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 6819381: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 800e68d6906734242119e4ea033422f037a79857 8292044: HttpClient doesn't handle 102 or 103 properly Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2024

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only context diffs in the import sections of Exchange.java and HttpClientImpl.java. Lgtm.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 1, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Aug 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

Going to push as commit 1000028.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2ec8717: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • 772c978: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 6819381: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2024
@openjdk openjdk bot closed this Aug 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@MBaesken Pushed as commit 1000028.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants