Skip to content

Conversation

@luchenlin
Copy link

@luchenlin luchenlin commented Aug 1, 2024

I backport this for parity with 17.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317343 needs maintainer approval

Issue

  • JDK-8317343: GC: Make TestHeapFreeRatio use createTestJvm (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2763/head:pull/2763
$ git checkout pull/2763

Update a local copy of the PR:
$ git checkout pull/2763
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2763/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2763

View PR using the GUI difftool:
$ git pr show -t 2763

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2763.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317343: GC: Make TestHeapFreeRatio use createTestJvm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 772c978: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 6819381: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c64bd3d6715304accd9a1e3266edd9d3d2353273 8317343: GC: Make TestHeapFreeRatio use createTestJvm Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 2, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

Going to push as commit a76c3af.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 8bb51e5: 8317635: Improve GetClassFields test to verify correctness of field order
  • 1000028: 8292044: HttpClient doesn't handle 102 or 103 properly
  • 2ec8717: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • 772c978: 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message
  • 6819381: 8280988: [XWayland] Click on title to request focus test failures
  • 15c5caa: 8317358: G1: Make TestMaxNewSize use createTestJvm
  • 4650ece: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2024
@openjdk openjdk bot closed this Aug 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@luchenlin Pushed as commit a76c3af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant