-
Notifications
You must be signed in to change notification settings - Fork 224
8280543: Update the "java" and "jcmd" tool specification for CDS #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
I testbuilt the manpages manually on Ubuntu 20.4, and checked that they looked okay and made sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks @TheRealMDoerr for review, @GoeLin for approval. /integrate |
Not a clean backport.
I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/277/head:pull/277
$ git checkout pull/277
Update a local copy of the PR:
$ git checkout pull/277
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/277/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 277
View PR using the GUI difftool:
$ git pr show -t 277
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/277.diff