Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280543: Update the "java" and "jcmd" tool specification for CDS #277

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Mar 22, 2022

Not a clean backport.

I had to remove mentioning of the "dynamic_dump" option since its not supported in jdk17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280543: Update the "java" and "jcmd" tool specification for CDS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/277/head:pull/277
$ git checkout pull/277

Update a local copy of the PR:
$ git checkout pull/277
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/277/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 277

View PR using the GUI difftool:
$ git pr show -t 277

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/277.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 22, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 39165613aa0430861e361a33a4925b85ea24fff1 8280543: Update the "java" and "jcmd" tool specification for CDS Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Mar 22, 2022
@tstuefe
Copy link
Member Author

tstuefe commented Mar 22, 2022

I testbuilt the manpages manually on Ubuntu 20.4, and checked that they looked okay and made sense.

@openjdk openjdk bot added the rfr label Mar 22, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 22, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280543: Update the "java" and "jcmd" tool specification for CDS

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 22, 2022
@tstuefe
Copy link
Member Author

tstuefe commented Mar 23, 2022

Thanks @TheRealMDoerr for review, @GoeLin for approval.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit d6eb281.
Since your change was applied there have been 2 commits pushed to the master branch:

  • d19ec6f: 8193682: Infinite loop in ZipOutputStream.close()
  • 937b55c: 8282583: Update BCEL md to include the copyright notice

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready rfr labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@tstuefe Pushed as commit d6eb281.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the tstuefe-backport-39165613 branch Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants