Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused #2772

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Aug 2, 2024

Backport of JDK-8304962

Testing

  • Local: Test passed
    • B5045306.java: Test results: passed: 1
  • Pipeline
    • linux-x64,x86, windows-aarch64,x64 macos-aarch64,x64 - passed
    • The failed test case is not related to current PR and has been fixed in master branch
  • Testing Machine: SAP nightlies passed on 2024-08-07
    • Automated jtreg test: jtreg_jdk_tier2
    • Started at 2024-08-06 21:10:46+01:00
    • sun/net/www/http/KeepAliveCache/B5045306.java: SUCCESSFUL GitHub 📊 - [21:36:33.819 -> 13,634 msec]

Progress

  • JDK-8304962 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2772/head:pull/2772
$ git checkout pull/2772

Update a local copy of the PR:
$ git checkout pull/2772
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2772/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2772

View PR using the GUI difftool:
$ git pr show -t 2772

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2772.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • f07c266: 8290966: G1: Record number of PLAB filled and number of direct allocations
  • 7a53368: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262
  • 966cafc: 7026262: HttpServer: improve handling of finished HTTP exchanges
  • 396e209: 8337669: [17u] Backport of JDK-8284047 missed to delete a file
  • 7230baf: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
  • ae7be19: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • 7f8fdbd: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/772c9786bd0954b93dfac4f89d92f3fc362bb444...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cddaf686e16424e9543be50a48b1c02337e79cf1 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2024

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Aug 8, 2024

/approval request "Backporting for parity with 17-pool-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-08-07”

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@amosshi
8304962: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 8, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Aug 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

Going to push as commit cf21d29.
Since your change was applied there have been 17 commits pushed to the master branch:

  • f07c266: 8290966: G1: Record number of PLAB filled and number of direct allocations
  • 7a53368: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262
  • 966cafc: 7026262: HttpServer: improve handling of finished HTTP exchanges
  • 396e209: 8337669: [17u] Backport of JDK-8284047 missed to delete a file
  • 7230baf: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
  • ae7be19: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • 7f8fdbd: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/772c9786bd0954b93dfac4f89d92f3fc362bb444...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2024
@openjdk openjdk bot closed this Aug 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2024
@openjdk
Copy link

openjdk bot commented Aug 8, 2024

@amosshi Pushed as commit cf21d29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8304962 branch August 8, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant