Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290966: G1: Record number of PLAB filled and number of direct allocations #2777

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Aug 2, 2024

Clean, low risk backport of a change to improve logging around full PLABs and direct allocations.

Passes the included test, as well as make test TEST=gc/g1 locally on linux x64.


Progress

  • JDK-8290966 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290966: G1: Record number of PLAB filled and number of direct allocations (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2777/head:pull/2777
$ git checkout pull/2777

Update a local copy of the PR:
$ git checkout pull/2777
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2777/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2777

View PR using the GUI difftool:
$ git pr show -t 2777

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2777.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2024

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290966: G1: Record number of PLAB filled and number of direct allocations

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 30205bb289e9b25d60474b24b891e15923071b5a 8290966: G1: Record number of PLAB filled and number of direct allocations Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

⚠️ @benty-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

I noticed Atomics can be improved a little bit:
https://bugs.openjdk.org/browse/JDK-8337815

@benty-amzn
Copy link
Author

/approval request Clean, low risk backport of a change to improve GC logging around full PLABs and direct allocations.

@openjdk
Copy link

openjdk bot commented Aug 5, 2024

@benty-amzn
8290966: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 5, 2024
@benty-amzn
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

Going to push as commit f07c266.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 7a53368: 8304963: HttpServer closes connection after processing HEAD after JDK-7026262
  • 966cafc: 7026262: HttpServer: improve handling of finished HTTP exchanges
  • 396e209: 8337669: [17u] Backport of JDK-8284047 missed to delete a file
  • 7230baf: 8283728: jdk.hotspot.agent: Wrong location for RISCV64ThreadContext.java
  • ae7be19: 8335536: Fix assertion failure in IdealGraphPrinter when append is true
  • 1f14f86: 8306929: Avoid CleanClassLoaderDataMetaspaces safepoints when previous versions are shared
  • 37726c5: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 66fa756: 8317112: Add screenshot for Frame/DefaultSizeTest.java

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2024
@openjdk openjdk bot closed this Aug 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@benty-amzn Pushed as commit f07c266.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants