8302800: Augment NaN handling tests of FDLIBM methods

[amosshi]

Backport of JDK-8302800

• This PR contains two PR
• commit 1 is made by the git apply which is clean
• commit 2 adds the missing file test/jdk/java/lang/Math/InverseTrigTests.java currently does not exist in jdk17u-dev, it was originally added by JDK-8302026 via commit

Testing

• Local: Test passed on MacOS 14.5 on Apple M1 Max
  • CubeRootTests.java: Test results: passed: 1
  • Expm1Tests.java: Test results: passed: 1
  • HyperbolicTests.java: Test results: passed: 1
  • Log10Tests.java: Test results: passed: 1
  • Log1pTests.java: Test results: passed: 1
  • Tests.java: Not applicable: not a test
  • InverseTrigTests.java: Test results: passed: 1
• Pipeline:
  • Linux, Windows - Passed
  • MacOS - Skipped (This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.)
• Testing Machine: SAP nightlies Passed on 2024-08-07
  • Automated jtreg test: jtreg_jdk_tier1, Started at 2024-08-06 20:35:20+01:00
  • java/lang/Math/CubeRootTests.java: SUCCESSFUL GitHub 📊 - [20:41:53.428 -> 166 msec]
  • java/lang/Math/Expm1Tests.java: SUCCESSFUL GitHub 📊 - [20:41:54.175 -> 253 msec]
  • java/lang/Math/HyperbolicTests.java: SUCCESSFUL GitHub 📊 - [20:41:54.428 -> 307 msec]
  • java/lang/Math/Log10Tests.java: SUCCESSFUL GitHub 📊 - [20:41:55.238 -> 196 msec]
  • java/lang/Math/Log1pTests.java: SUCCESSFUL GitHub 📊 - [20:41:55.434 -> 202 msec]
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [20:41:55.038 -> 199 msec]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8302800 needs maintainer approval

Issue

• JDK-8302800: Augment NaN handling tests of FDLIBM methods (Sub-task - P4 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2779/head:pull/2779
$ git checkout pull/2779

Update a local copy of the PR:
$ git checkout pull/2779
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2779

View PR using the GUI difftool:
$ git pr show -t 2779

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2779.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8302800: Augment NaN handling tests of FDLIBM methods

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 245 new commits pushed to the master branch:

• be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
• d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
• 2e3ca31: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
• 27c92b6: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
• 61e0a11: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
• 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
• ... and 235 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (68f74209)

[MBaesken]

JDK-8302026 which contains the 'missing' InverseTrigTests.java test was never backported to 17 so please check again that the test is really stable.

[amosshi]

Hi @MBaesken ,

FYI: we have monitored the test case for another week, so far so good, all passed:

• Started at 2024-08-15 00:54:43+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [01:00:38.234 -> 578 msec]
• Started at 2024-08-13 22:27:17+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [22:41:57.003 -> 3,551 msec]
• Started at 2024-08-12 09:51:13+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [09:57:48.239 -> 119 msec]
• Started at 2024-08-11 22:25:03+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [22:39:57.485 -> 454 msec]
• Started at 2024-08-09 23:02:03+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [23:16:11.723 -> 577 msec]
• Started at 2024-08-09 18:38:52+01:00
  • Automated jtreg test: jtreg_jdk_tier1
  • java/lang/Math/InverseTrigTests.java: SUCCESSFUL GitHub 📊 - [18:53:29.160 -> 515 msec]

Regards
Amos
A Happy Developer

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[amosshi]

/approval request "Backporting for parity with 17.0.13-oracle. No risk, test fix. Un-Clean backport. Test passes and SAP nightlies pass on 2024-08-07,15”

[openjdk]

@amosshi
8302800: The approval request has been created successfully.

[GoeLin]

There are red tests, what is wrong?

[amosshi]

There are red tests, what is wrong?

Reason

• This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

Action

• I will re-trigger

[amosshi]

/integrate

[openjdk]

Going to push as commit 803c2c2.
Since your change was applied there have been 249 commits pushed to the master branch:

• cd0bb4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
• 1887a80: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
• 64ab2fa: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
• 97e4a93: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
• d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
• ... and 239 more: https://git.openjdk.org/jdk17u-dev/compare/d953de6b2cb0572ea24b9e02952aa5aedee6cc64...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit 803c2c2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.