Skip to content

8313256: Exclude failing multicast tests on AIX#2780

Closed
amosshi wants to merge 2 commits intoopenjdk:masterfrom
amosshi:backport-8313256
Closed

8313256: Exclude failing multicast tests on AIX#2780
amosshi wants to merge 2 commits intoopenjdk:masterfrom
amosshi:backport-8313256

Conversation

@amosshi
Copy link
Contributor

@amosshi amosshi commented Aug 3, 2024

Backport of JDK-8313256

  • This PR contains two commit
  • commit 1 is generated by git apply command, which is clean
  • commit 2 is the manual merge of the test/jdk/ProblemList.txt.rej file

Contents of test/jdk/ProblemList.txt.rej

@@ -586,13 +587,16 @@
 
 # jdk_net
 
-java/net/MulticastSocket/NoLoopbackPackets.java                 7122846 macosx-all
-java/net/MulticastSocket/SetLoopbackMode.java                   7122846 macosx-all
+java/net/MulticastSocket/NoLoopbackPackets.java                 7122846,8308807 macosx-all,aix-ppc64
+java/net/MulticastSocket/SetLoopbackMode.java                   7122846,8308807 macosx-all,aix-ppc64
 
-java/net/MulticastSocket/Test.java                              7145658 macosx-all
+java/net/MulticastSocket/Test.java                              7145658,8308807 macosx-all,aix-ppc64
 
 java/net/ServerSocket/AcceptInheritHandle.java                  8211854 aix-ppc64
 
+java/net/MulticastSocket/B6427403.java                          8308807 aix-ppc64
+java/net/MulticastSocket/SetOutgoingIf.java                     8308807 aix-ppc64
+
 ############################################################################
 
 # jdk_nio

Testing

  • Local: Not applicable (aix-ppc64)
  • Pipeline: All checks have passed
  • Testing Machine: SAP nightlies Passed on 2024-08-07
    • Automated jtreg test: jtreg_jdk_tier3, Started at 2024-08-06 22:04:38+01:00
      • sun/management/jdp/JdpDefaultsTest.java: SKIPPED [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • sun/management/jdp/JdpJmxRemoteDynamicPortTest.java: SKIPPED [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • sun/management/jdp/JdpSpecificAddressTest.java: SKIPPED [Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • sun/management/jdp/JdpOffTest.java: SUCCESSFUL GitHub 📊 - [22:20:33.777 -> 12,159 msec]
    • Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-06 21:10:46+01:00
      • java/net/MulticastSocket/NoLoopbackPackets.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • java/net/MulticastSocket/SetLoopbackMode.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • java/net/MulticastSocket/Test.java: SKIPPED[Filter: jtregExcludeListFilter - Test has been excluded by an exclude list] GitHub 📊 - [0 msec]
      • java/net/MulticastSocket/B6427403.java: SUCCESSFUL GitHub 📊 - [21:22:00.602 -> 156 msec]
      • java/net/MulticastSocket/SetOutgoingIf.java: SUCCESSFUL GitHub 📊 - [21:22:08.500 -> 273 msec]
      • java/nio/channels/DatagramChannel/AfterDisconnect.java: SUCCESSFUL GitHub 📊 - [21:23:10.918 -> 9,012 msec]

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313256 needs maintainer approval

Issue

  • JDK-8313256: Exclude failing multicast tests on AIX (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2780/head:pull/2780
$ git checkout pull/2780

Update a local copy of the PR:
$ git checkout pull/2780
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2780/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2780

View PR using the GUI difftool:
$ git pr show -t 2780

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2780.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2024

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2024

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313256: Exclude failing multicast tests on AIX

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • d90d028: 8318089: Class space not marked as such with NMT when CDS is off
  • 5e0e2e3: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native
  • 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
  • 185e69a: 8334166: Enable binary check
  • 9990cfa: 8272558: IR Test Framework README misses some flags
  • 0330069: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
  • 7f78f21: 8316285: Opensource JButton manual tests
  • c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • 971b01a: 8315965: Open source various AWT applet tests
  • 0b789c1: 8332113: Update nsk.share.Log to be always verbose
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/7f8fdbd0940c30968f38a226e52e9ce8264a1e74...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 98a915a54ce62da7cebc1f0ab07dab276291a1d1 8313256: Exclude failing multicast tests on AIX Aug 3, 2024
@openjdk
Copy link

openjdk bot commented Aug 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 3, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 8, 2024

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@amosshi
Copy link
Contributor Author

amosshi commented Aug 16, 2024

/approval request "Backporting for parity with 17.0.13-oracle. No risk, test fix. Un-Clean backport. Test passes and SAP nightlies pass on 2024-08-07”

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@amosshi
8313256: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 16, 2024
@amosshi
Copy link
Contributor Author

amosshi commented Aug 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

Going to push as commit dfc21bf.
Since your change was applied there have been 28 commits pushed to the master branch:

  • e291bfa: 8314837: 5 compiled/codecache tests ignore VM flags
  • 7b205d6: 8325022: Incorrect error message on client authentication
  • d90d028: 8318089: Class space not marked as such with NMT when CDS is off
  • 5e0e2e3: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native
  • 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
  • 185e69a: 8334166: Enable binary check
  • 9990cfa: 8272558: IR Test Framework README misses some flags
  • 0330069: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
  • 7f78f21: 8316285: Opensource JButton manual tests
  • c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/7f8fdbd0940c30968f38a226e52e9ce8264a1e74...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 16, 2024
@openjdk openjdk bot closed this Aug 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@amosshi Pushed as commit dfc21bf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8313256 branch August 16, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants