Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused #2781

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 3, 2024

Hi all,

This pull request contains a backport of JDK-8304962, commit cddaf686 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by Daniel Jeliński on 28 Mar 2023 and was reviewed by Jaikiran Pai.

Thanks!


Progress

  • JDK-8304962 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2781/head:pull/2781
$ git checkout pull/2781

Update a local copy of the PR:
$ git checkout pull/2781
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2781/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2781

View PR using the GUI difftool:
$ git pr show -t 2781

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2781.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport cddaf686e16424e9543be50a48b1c02337e79cf1 8304962: sun/net/www/http/KeepAliveCache/B5045306.java: java.lang.RuntimeException: Failed: Initial Keep Alive Connection is not being reused Aug 3, 2024
@openjdk
Copy link

openjdk bot commented Aug 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 3, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2024

Webrevs

@RealCLanger
Copy link
Contributor Author

Closing in favor of #2772 (Sorry @amosshi, didn't see that you were already doing this)

@RealCLanger RealCLanger closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant