Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8330814: Cleanups for KeepAliveCache tests #2790

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 9, 2024

Backporting the cleanups for KeepAliveCache tests. Now with all prerequisites in place, it applies nearly clean. Only in test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java there was a little modification due to the different HttpServer API in 17 which lacks the constructor with all the options that is used in higher releases.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330814 needs maintainer approval

Issue

  • JDK-8330814: Cleanups for KeepAliveCache tests (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2790/head:pull/2790
$ git checkout pull/2790

Update a local copy of the PR:
$ git checkout pull/2790
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2790/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2790

View PR using the GUI difftool:
$ git pr show -t 2790

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2790.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2024

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330814: Cleanups for KeepAliveCache tests

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
  • d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
  • 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
  • d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
  • 2e3ca31: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
  • 27c92b6: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 61e0a11: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
  • 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • ... and 20 more: https://git.openjdk.org/jdk17u-dev/compare/13f6ab3e195419ff8a3987f9b98035f1581292cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a1a56cf88b1d4022441a51aac53f9f7cf47096fb 8330814: Cleanups for KeepAliveCache tests Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 9, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@MBaesken
Copy link
Member

sun/net/www/http/KeepAliveCache/B5045306.java fails now in our nightly tests; please check this before integrating.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 24, 2024
@RealCLanger
Copy link
Contributor Author

Closing in favor of #2813.

@RealCLanger RealCLanger deleted the backport-RealCLanger-a1a56cf8-master branch August 27, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants