8318089: Class space not marked as such with NMT when CDS is off

[ansteiner]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8318089 needs maintainer approval

Issue

• JDK-8318089: Class space not marked as such with NMT when CDS is off (Bug - P4 - Approved)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2794/head:pull/2794
$ git checkout pull/2794

Update a local copy of the PR:
$ git checkout pull/2794
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2794/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2794

View PR using the GUI difftool:
$ git pr show -t 2794

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2794.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asteiner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ansteiner This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318089: Class space not marked as such with NMT when CDS is off

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 845 new commits pushed to the master branch:

• 5e0e2e3: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native
• 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
• 185e69a: 8334166: Enable binary check
• 9990cfa: 8272558: IR Test Framework README misses some flags
• 0330069: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• 7f78f21: 8316285: Opensource JButton manual tests
• c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
• 971b01a: 8315965: Open source various AWT applet tests
• 0b789c1: 8332113: Update nsk.share.Log to be always verbose
• 2e9152d: 8336928: GHA: Bundle artifacts removal broken
• ... and 835 more: https://git.openjdk.org/jdk17u-dev/compare/e80200f3ddaf57fa8a2ccc23222242d0c997bea7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @ansteiner This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (88795d15)

[ansteiner]

/approval request

[openjdk]

@ansteiner
8318089: The approval request has been created successfully.

[tstuefe]

LGTM

[ansteiner]

/integrate

[openjdk]

@ansteiner
Your change (at version 88795d1) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit d90d028.
Since your change was applied there have been 845 commits pushed to the master branch:

• 5e0e2e3: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native
• 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"
• 185e69a: 8334166: Enable binary check
• 9990cfa: 8272558: IR Test Framework README misses some flags
• 0330069: 8316973: GC: Make TestDisableDefaultGC use createTestJvm
• 7f78f21: 8316285: Opensource JButton manual tests
• c09ca4e: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
• 971b01a: 8315965: Open source various AWT applet tests
• 0b789c1: 8332113: Update nsk.share.Log to be always verbose
• 2e9152d: 8336928: GHA: Bundle artifacts removal broken
• ... and 835 more: https://git.openjdk.org/jdk17u-dev/compare/e80200f3ddaf57fa8a2ccc23222242d0c997bea7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @ansteiner Pushed as commit d90d028.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.