Skip to content

8307648: java/net/httpclient/ExpectContinueTest.java timed out #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Aug 13, 2024

The backport is not clean.

JDK17 does not have JDK-8293786. As a result, the debug log is not merged into Stream::incoming_reset method. These changes could be skipped because they are not required for this functionality

Also, ExpectContinueTest test was added in JDK21 as part of JDK-8286171. Not backported to JDK17. The changes for this test are skipped

All java/net/httpclient JTREG tests passed


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8307648 needs maintainer approval

Issue

  • JDK-8307648: java/net/httpclient/ExpectContinueTest.java timed out (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2799/head:pull/2799
$ git checkout pull/2799

Update a local copy of the PR:
$ git checkout pull/2799
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2799/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2799

View PR using the GUI difftool:
$ git pr show -t 2799

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2799.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/2798 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 04b0e785f6b9b4629b77bb19f2b072434be4951c 8307648: java/net/httpclient/ExpectContinueTest.java timed out Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 13, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 13, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/2798 to master September 22, 2024 17:02
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has been closed without being integrated and the target branch of this pull request has been updated as the previous branch was deleted. This means that changes from the parent pull request will start to show up in this pull request. If closing the parent pull request was done in error, it will need to be re-opened and this pull request will need to manually be retargeted again.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2024

@alexeybakhtin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Nov 17, 2024
@bridgekeeper bridgekeeper bot added oca Needs verification of OCA signatory status and removed oca Needs verification of OCA signatory status labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant