Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' #2805

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 14, 2024


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332903 needs maintainer approval

Issue

  • JDK-8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2805/head:pull/2805
$ git checkout pull/2805

Update a local copy of the PR:
$ git checkout pull/2805
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2805/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2805

View PR using the GUI difftool:
$ git pr show -t 2805

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2805.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 14, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

  • e50b815: 8339081: Bump update version for OpenJDK: jdk-17.0.14
  • 99b7468: 8330814: Cleanups for KeepAliveCache tests
  • 03cbfaa: 8315024: Vector API FP reduction tests should not test for exact equality
  • 803c2c2: 8302800: Augment NaN handling tests of FDLIBM methods
  • cd0bb4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
  • 1887a80: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 64ab2fa: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
  • 97e4a93: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
  • be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/03300692ec6c5e73987e00f34c34ac3fbe7c396a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 113a2c028dc3b9abb6229d5f0b812b54a9b61011 8332903: ubsan: opto/output.cpp:1002:18: runtime error: load of value 171, which is not a valid value for type 'bool' Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 14, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 14, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

Going to push as commit 6f382d1.
Since your change was applied there have been 28 commits pushed to the master branch:

  • e50b815: 8339081: Bump update version for OpenJDK: jdk-17.0.14
  • 99b7468: 8330814: Cleanups for KeepAliveCache tests
  • 03cbfaa: 8315024: Vector API FP reduction tests should not test for exact equality
  • 803c2c2: 8302800: Augment NaN handling tests of FDLIBM methods
  • cd0bb4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
  • 1887a80: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
  • 64ab2fa: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
  • 97e4a93: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
  • be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
  • ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/03300692ec6c5e73987e00f34c34ac3fbe7c396a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2024
@openjdk openjdk bot closed this Aug 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 28, 2024
@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@MBaesken Pushed as commit 6f382d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant