8308891: TestCDSVMCrash.java needs @requires vm.cds

[amosshi]

Backport of JDK-8308891

Testing

• Local: Test passed on MacOS 14.6.1 on Apple M1 Max
  • TestCDSVMCrash.java: Test results: passed: 1
• Pipeline: All checks have passed
• Testing Machine: SAP nightlies Passed on 2024-08-17
  • Automated jtreg test: jtreg_hotspot_tier1, Started at 2024-08-16 20:49:01+01:00
  • runtime/cds/TestCDSVMCrash.java: SUCCESSFUL GitHub 📊 - [20:52:31.382 -> 2,093 msec]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8308891 needs maintainer approval

Issue

• JDK-8308891: TestCDSVMCrash.java needs @requires vm.cds (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2809/head:pull/2809
$ git checkout pull/2809

Update a local copy of the PR:
$ git checkout pull/2809
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2809

View PR using the GUI difftool:
$ git pr show -t 2809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2809.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308891: TestCDSVMCrash.java needs @requires vm.cds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
• 25537e9: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
• d642a13: 8320608: Many jtreg printing tests are missing the @printer keyword
• dfc21bf: 8313256: Exclude failing multicast tests on AIX
• e291bfa: 8314837: 5 compiled/codecache tests ignore VM flags
• 7b205d6: 8325022: Incorrect error message on client authentication
• d90d028: 8318089: Class space not marked as such with NMT when CDS is off
• 5e0e2e3: 8337038: Test java/nio/file/attribute/BasicFileAttributeView/CreationTime.java shoud set as /native
• 1f45ae8: 8304375: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Expected at least some events to be out of order! Reuse = false"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (ab5a37bc)

[amosshi]

/approval request "Backporting as JDK-8321933 dependency. No risk, test fix. Clean backport. Test passes and SAP nightlies pass on 2024-08-17”

[openjdk]

@amosshi
8308891: The approval request has been created successfully.

[amosshi]

/integrate

[openjdk]

Going to push as commit c103409.
Since your change was applied there have been 15 commits pushed to the master branch:

• d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• 6cbedd9: 8273216: JCMD does not work across container boundaries with Podman
• d5d26be: 8315936: Parallelize gc/stress/TestStressG1Humongous.java test
• 2e3ca31: 8303891: Speed up Zip64SizeTest using a small ZIP64 file
• 27c92b6: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
• 61e0a11: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
• 698f0e3: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
• 25537e9: 8298596: vmTestbase/nsk/sysdict/vm/stress/chain/chain008/chain008.java fails with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom"
• d642a13: 8320608: Many jtreg printing tests are missing the @printer keyword
• dfc21bf: 8313256: Exclude failing multicast tests on AIX
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/185e69a3f73e03b480d6c519fbde26af2b350a8d...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit c103409.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.