-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8327474: Review use of java.io.tmpdir in jdk tests #2811
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/approval request Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low. |
@sendaoYan |
@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi, can anyone take look tihs PR. |
Hi all,
This pull request contains a backport of commit af6c5854 from the openjdk/jdk21u-dev repository.
The commit being backported was authored by Goetz Lindenmaier on 22 Apr 2024 and had no reviewers.
The backport not clean because jdk17u-dev doesn't have
test/jdk/jdk/jfr/threading/TestManyVirtualThreads.java
, all other files are backported cleanly.Existing tests should be reviewed to check the usage of java.io.tmpdir. Test fix only, the risk is low.
Additional testing:
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2811/head:pull/2811
$ git checkout pull/2811
Update a local copy of the PR:
$ git checkout pull/2811
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2811/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2811
View PR using the GUI difftool:
$ git pr show -t 2811
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2811.diff
Webrev
Link to Webrev Comment