8330814: Cleanups for KeepAliveCache tests

[amosshi]

Backport of JDK-8330814

• This PR has two commits
• commit 1 is a clean git patch from original commit
• commit 2 is fixing the following compile error
  • The fix is in line with e96daf3#diff-9aaf6eb570572e1a22b661c23e76f330d090280ef60e7390d0ab421d48a6558eR68 from @RealCLanger

----------System.err:(8/634)----------
/Users/I048686/SAPDevelop/github.com/dev-8330814-17/test/jdk/sun/net/www/http/KeepAliveCache/B5045306.java:73: error: no suitable method found for create(InetSocketAddress,int,String,SimpleHttpTransactionHandler)
            server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10, "/", new SimpleHttpTransactionHandler());
                               ^
    method HttpServer.create() is not applicable
      (actual and formal argument lists differ in length)
    method HttpServer.create(InetSocketAddress,int) is not applicable
      (actual and formal argument lists differ in length)
1 error
result: Failed. Compilation failed: Compilation failed

Testing

• Local: Test passed on MacOS 14.6.1 on Apple M1 Max
  • B5045306.java: Test results: passed: 1
  • B8291637.java: Test results: passed: 1
  • B8293562.java: Test results: passed: 1
  • KeepAliveProperty.java: Test results: passed: 1
  • KeepAliveTimerThread.java: Test results: passed: 1
• Pipeline: All checks have passed
• Testing Machine: SAP nightlies SUCCESSFUL on 2024-08-23
  • Automated jtreg test: jtreg_jdk_tier2, Started at 2024-08-23 19:44:34+01:00
  • sun/net/www/http/KeepAliveCache/B5045306.java: SUCCESSFUL GitHub 📊 - [20:10:08.445 -> 14,486 msec]
  • sun/net/www/http/KeepAliveCache/B8291637.java: SUCCESSFUL GitHub 📊 - [20:10:08.455 -> 20,795 msec]
  • sun/net/www/http/KeepAliveCache/B8293562.java: SUCCESSFUL GitHub 📊 - [20:10:09.152 -> 7,188 msec]
  • sun/net/www/http/KeepAliveCache/KeepAliveProperty.java: SUCCESSFUL GitHub 📊 - [20:10:09.356 -> 13,344 msec]
  • sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java: SUCCESSFUL GitHub 📊 - [20:10:09.722 -> 2,621 msec]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8330814 needs maintainer approval

Issue

• JDK-8330814: Cleanups for KeepAliveCache tests (Bug - P4 - Approved)

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2813/head:pull/2813
$ git checkout pull/2813

Update a local copy of the PR:
$ git checkout pull/2813
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2813

View PR using the GUI difftool:
$ git pr show -t 2813

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2813.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ashi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330814: Cleanups for KeepAliveCache tests

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 03cbfaa: 8315024: Vector API FP reduction tests should not test for exact equality
• 803c2c2: 8302800: Augment NaN handling tests of FDLIBM methods
• cd0bb4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
• 1887a80: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
• 64ab2fa: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
• 97e4a93: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/698f0e37746bffe61fc59cd553d3582d0e004097...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (e5820551)

[amosshi]

/approval request "No risk, test fix. Un-Clean backport. Test passes and SAP nightlies pass on 2024-08-23”

[openjdk]

@amosshi
8330814: The approval request has been created successfully.

[RealCLanger]

Looks good and similar to my intial attempt in #2790 which still had an issue in B5045306. This seems to be fixed in this PR through the change in line 73 of B5045306.java:

     server = HttpServer.create(new InetSocketAddress(InetAddress.getLocalHost(), 0), 10);

to

     server = HttpServer.create(new InetSocketAddress(InetAddress.getLoopbackAddress(), 0), 10);

Otherwise looks the same and passes testing, so LGTM.

[amosshi]

/integrate

[openjdk]

Going to push as commit 99b7468.
Since your change was applied there have been 15 commits pushed to the master branch:

• 03cbfaa: 8315024: Vector API FP reduction tests should not test for exact equality
• 803c2c2: 8302800: Augment NaN handling tests of FDLIBM methods
• cd0bb4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
• 1887a80: 8332248: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java failed with RuntimeException
• 64ab2fa: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
• 97e4a93: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• be4f913: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8dbd677: 8315576: compiler/codecache/CodeCacheFullCountTest.java fails after JDK-8314837
• c103409: 8308891: TestCDSVMCrash.java needs @requires vm.cds
• d12077d: 8284316: Support accessibility ManualTestFrame.java for non SwingSet tests
• ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/698f0e37746bffe61fc59cd553d3582d0e004097...master

Your commit was automatically rebased without conflicts.

[openjdk]

@amosshi Pushed as commit 99b7468.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.