Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319567: Update java/lang/invoke tests to support vm flags #2817

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 21, 2024

Hi all,
This backport of openjdk/jdk#16666 to jdk17u-dev, to make the test will support VM flags passed to jtreg, and a couple tests that ignore VM flags should use ProcessTools::createLimtiedTestJavaProcessBuilder and marks the test with @requires vm.flagless.

Addiontial testing:

  • linux x64 whole jtreg tests
  • linux aarch64 whole jtreg tests

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8319677 needs maintainer approval
  • JDK-8319568 needs maintainer approval
  • Change must not contain extraneous whitespace
  • JDK-8319676 needs maintainer approval
  • Commit message must refer to an issue
  • JDK-8319672 needs maintainer approval
  • JDK-8319567 needs maintainer approval

Issues

  • JDK-8319567: Update java/lang/invoke tests to support vm flags (Sub-task - P4)
  • JDK-8319568: Update java/lang/reflect/exeCallerAccessTest/CallerAccessTest.java to accept vm flags (Sub-task - P4)
  • JDK-8319672: Several classloader tests ignore VM flags (Sub-task - P4)
  • JDK-8319676: A couple of jdk/modules/incubator/ tests ignore VM flags (Sub-task - P4)
  • JDK-8319677: Test jdk/internal/misc/VM/RuntimeArguments.java should be marked as flagless (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2817/head:pull/2817
$ git checkout pull/2817

Update a local copy of the PR:
$ git checkout pull/2817
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2817/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2817

View PR using the GUI difftool:
$ git pr show -t 2817

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2817.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 1588dd934ce4e00a060e329b80f721d894559597 8319567: Update java/lang/invoke tests to support vm flags Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 21, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2024

Webrevs

@sendaoYan sendaoYan marked this pull request as draft August 21, 2024 09:43
@openjdk openjdk bot removed the rfr Pull request is ready for review label Aug 21, 2024
@sendaoYan
Copy link
Member Author

Depend JDK-8315097

@sendaoYan sendaoYan closed this Aug 21, 2024
@sendaoYan sendaoYan deleted the jbs1588dd934ce4e00a060e329b80f721d894559597 branch August 21, 2024 09:56
@sendaoYan sendaoYan restored the jbs1588dd934ce4e00a060e329b80f721d894559597 branch August 21, 2024 12:49
@sendaoYan sendaoYan reopened this Aug 21, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2024

@sendaoYan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/open

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@sendaoYan This pull request is already open

@sendaoYan
Copy link
Member Author

Give up backport to 17u.

@sendaoYan sendaoYan closed this Nov 14, 2024
@sendaoYan sendaoYan deleted the jbs1588dd934ce4e00a060e329b80f721d894559597 branch November 14, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant