8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null

[MBaesken]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8332825 needs maintainer approval

Issue

• JDK-8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2829/head:pull/2829
$ git checkout pull/2829

Update a local copy of the PR:
$ git checkout pull/2829
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2829

View PR using the GUI difftool:
$ git pr show -t 2829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2829.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 3248a61: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
• 51395cf: 8326611: Clean up vmTestbase/nsk/stress/stack tests
• 81ad499: 8294726: Update URLs in minefield tests
• 98586bb: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• d92d633: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
• 91849bf: Merge
• f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
• aa46c35: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• 6261dd7: 8339470: [17u] More defensive fix for 8163921
• 7d82858: 8331864: Update Public Suffix List to 1cbd6e7
• ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/6f382d1fcfb514ab11e991ceb3c94967e8cbc054...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (62b0c10d)

[tstuefe]

Hmm. innerp can never be null. If anything, we should assert.

[GoeLin]

Hi,
I don't understand. First, innerp is not checked for null. Second: does the code in 17 differ to 21&head? Else we should change this to an assertion in head, first.

[tstuefe]

Hi Goetz!

innerp is the result of

  u_char* get_user_ptr() const {
    assert(_base_addr != nullptr, "Not wrapping any memory");
    return _base_addr + sizeof(GuardHeader);
  }

which cannot return null. _base_addr is the result of a malloc and we only ever enter this path if that malloc succeeded. It is also asserted at least twice.

Cheers, Thomas

[GoeLin]

Yes, but the new code checks whether "ptr" is null. That is passed in as an argument.

[MBaesken]

we call
GuardedMemory::wrap_copy(no_data, 0);
This makes ptr == NULL / nullptr .
See the full backtrace here openjdk/jdk#19382
It is a clean backport so should be the same in 17. The check was added to handle to no_data / length 0 case .

[tstuefe]

Okay, I just misread the code. Sorry for the confusion, I was too tired.

[GoeLin]

GHA failure: ClhsdbFindPC is known to fail in GHA on mac aarch. Here we see a different error situation, the test times out. But this surely is unrelated to this fix.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 7161e29.
Since your change was applied there have been 38 commits pushed to the master branch:

• 81b2c8d: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable
• 6f99109: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
• 3248a61: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
• 51395cf: 8326611: Clean up vmTestbase/nsk/stress/stack tests
• 81ad499: 8294726: Update URLs in minefield tests
• 98586bb: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
• d92d633: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
• 91849bf: Merge
• f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
• aa46c35: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
• ... and 28 more: https://git.openjdk.org/jdk17u-dev/compare/6f382d1fcfb514ab11e991ceb3c94967e8cbc054...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 7161e29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.