-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273979: move some os time related functions to os_posix for POSIX platforms #2831
base: master
Are you sure you want to change the base?
8273979: move some os time related functions to os_posix for POSIX platforms #2831
Conversation
👋 Welcome back rvansa! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
Hi @rvansa |
Hi @GoeLin , understood, though I am rather trying to be honest than making up a synthetic argument. Since it was accepted in the mainline I could say that it is an improvement in code quality. MacOS should be tested here in GHA, regrettably I don't know where to get AIX for testing. |
Hi @rvansa @suchismith1993, |
@rvansa I am currently facing some issue with my AIX development machine. Some migration in progress. |
@suchismith1993 No hurry, but it would be nice if you can try in a few weeks. Thank you! |
Hi, I removed the approval label for now from the JBS issue. Label again if it is tested. Thanks. |
Hi all,
This pull request contains a backport of commit 1c6fa113 from the openjdk/jdk repository.
The commit being backported was authored by Matthias Baesken on 23 Sep 2021 and was reviewed by David Holmes and Lutz Schmidt.
The backport applies cleanly, was created by the /backport command.
Thanks!
Progress
Warning
8273979: move some os time related functions to os_posix for POSIX platforms
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2831/head:pull/2831
$ git checkout pull/2831
Update a local copy of the PR:
$ git checkout pull/2831
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2831/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2831
View PR using the GUI difftool:
$ git pr show -t 2831
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2831.diff
Webrev
Link to Webrev Comment