8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

[mmyxym]

Clean backport of fix of soft-ref cleaning in Parallel Full GC.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8335493 needs maintainer approval

Issue

• JDK-8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2838/head:pull/2838
$ git checkout pull/2838

Update a local copy of the PR:
$ git checkout pull/2838
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2838/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2838

View PR using the GUI difftool:
$ git pr show -t 2838

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2838.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mmyxym This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 90b0fb0: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 9150f50: 8337780: RISC-V: C2: Change C calling convention for sp to NS
• b2c92fd: 8319817: Charset constructor should make defensive copy of aliases
• 42b5e12: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer
• 3ddae29: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
• acfce69: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @mmyxym This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (1c68ee49)

[mmyxym]

/approval request It's for fixing soft-ref resetting in Parallel Full GC. The risk is very low.

[openjdk]

@mmyxym
8335493: The approval request has been created successfully.

[mmyxym]

/integrate

[openjdk]

@mmyxym
Your change (at version 1c68ee4) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit d2cae5d.
Since your change was applied there have been 7 commits pushed to the master branch:

• dc69e05: 8325587: Shenandoah: ShenandoahLock should allow blocking in VM
• 90b0fb0: 8332589: ubsan: unix/native/libjava/ProcessImpl_md.c:562:5: runtime error: null pointer passed as argument 2, which is declared to never be null
• 9150f50: 8337780: RISC-V: C2: Change C calling convention for sp to NS
• b2c92fd: 8319817: Charset constructor should make defensive copy of aliases
• 42b5e12: 8287003: InputStreamReader::read() can return zero despite writing a char in the buffer
• 3ddae29: 8331789: ubsan: deoptimization.cpp:403:29: runtime error: load of value 208, which is not a valid value for type 'bool'
• acfce69: 8332904: ubsan ppc64le: c1_LIRGenerator_ppc.cpp:581:21: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'long int'

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @mmyxym Pushed as commit d2cae5d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.