Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281771: Crash in java_lang_invoke_MethodType::print_signature #284

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 25, 2022

Clean backport of JDK-8281771


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281771: Crash in java_lang_invoke_MethodType::print_signature

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/284/head:pull/284
$ git checkout pull/284

Update a local copy of the PR:
$ git checkout pull/284
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 284

View PR using the GUI difftool:
$ git pr show -t 284

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/284.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a24498b777b76c04d7e6da0a8b5fb501f2fb4944 8281771: Crash in java_lang_invoke_MethodType::print_signature Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 25, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281771: Crash in java_lang_invoke_MethodType::print_signature

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9923714: 8280041: Retry loop issues in java.io.ClassCache

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 25, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit 92bbdde.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b16d037: 8270797: ShortECDSA.java test is not complete
  • 86ac4ab: 8278549: UNIX sun/font coding misses SUSE distro detection on recent distro SUSE 15
  • 8d7f26b: 8278065: Refactor subclassAudits to use ClassValue
  • 9923714: 8280041: Retry loop issues in java.io.ClassCache

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@TheRealMDoerr Pushed as commit 92bbdde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant