Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' #2847

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 4, 2024

Backport of 8332720, NULL was still in 17u-dev , that's why not clean


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332720 needs maintainer approval

Issue

  • JDK-8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2847/head:pull/2847
$ git checkout pull/2847

Update a local copy of the PR:
$ git checkout pull/2847
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2847

View PR using the GUI difftool:
$ git pr show -t 2847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2847.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'

Reviewed-by: mdoerr, lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 91849bf: Merge
  • f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • aa46c35: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6261dd7: 8339470: [17u] More defensive fix for 8163921
  • 7d82858: 8331864: Update Public Suffix List to 1cbd6e7
  • 878ceeb: 8071693: Introspector ignores default interface methods
  • 2886a39: 8293877: Rewrite MineField test
  • fb79714: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 2001d39: 8274505: Too weak variable type leads to unnecessary cast in java.desktop
  • 57a1ad1: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/d2e3de236e583adcb2480db647cce759ec68824d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e19a421c30534566ba0dea0fa84f812ebeecfc87 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array' Sep 4, 2024
@openjdk
Copy link

openjdk bot commented Sep 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 4, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Sep 4, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the approval label Sep 5, 2024
@GoeLin
Copy link
Member

GoeLin commented Sep 11, 2024

GHA failure: the well known ClhsdbFindPC issue, today also ClhsdbFlags with the same error

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 11, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 11, 2024

Going to push as commit d92d633.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 91849bf: Merge
  • f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • aa46c35: 8337664: Distrust TLS server certificates issued after Oct 2024 and anchored by Entrust Root CAs
  • 6261dd7: 8339470: [17u] More defensive fix for 8163921
  • 7d82858: 8331864: Update Public Suffix List to 1cbd6e7
  • 878ceeb: 8071693: Introspector ignores default interface methods
  • 2886a39: 8293877: Rewrite MineField test
  • fb79714: 8276763: java/nio/channels/SocketChannel/AdaptorStreams.java fails with "SocketTimeoutException: Read timed out"
  • 2001d39: 8274505: Too weak variable type leads to unnecessary cast in java.desktop
  • 57a1ad1: 8269770: nsk tests should start IOPipe channel before launch debuggee - Debugee.prepareDebugee
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/d2e3de236e583adcb2480db647cce759ec68824d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 11, 2024
@openjdk openjdk bot closed this Sep 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 11, 2024
@openjdk
Copy link

openjdk bot commented Sep 11, 2024

@MBaesken Pushed as commit d92d633.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants