-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331864: Update Public Suffix List to 1cbd6e7 #2851
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
GHA failure: Well known issue with ClhsdbFindPC. Unrelated. |
|
/integrate |
Going to push as commit 7d82858.
Your commit was automatically rebased without conflicts. |
Fix request [17u]
I backport this for parity with 17.0.14-oracle.
One of the required updates of meta information.
After adapting the paths, the patch applies clean.
Test passes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2851/head:pull/2851
$ git checkout pull/2851
Update a local copy of the PR:
$ git checkout pull/2851
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2851/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2851
View PR using the GUI difftool:
$ git pr show -t 2851
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2851.diff
Webrev
Link to Webrev Comment