Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 #2861

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Sep 10, 2024

Hi all,

This pull request contains a backport of commit ad5656f7 from the openjdk/jdk21u-dev repository.

The commit being backported was authored by SendaoYan on 10 Sep 2024 and was reviewed by Severin Gehwolf.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • JDK-8338748 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2861/head:pull/2861
$ git checkout pull/2861

Update a local copy of the PR:
$ git checkout pull/2861
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2861

View PR using the GUI difftool:
$ git pr show -t 2861

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2861.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 22bcb90: 8338402: GHA: some of bundles may not get removed
  • 20bd36c: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 5b94895: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion
  • 4f32fca: 8332777: Update JCStress test suite
  • 92c2465: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
  • 08b9698: 8330621: Make 5 compiler tests use ProcessTools.executeProcess
  • 9def563: 8328957: Update PKCS11Test.java to not use hardcoded path
  • f75765a: 8326898: NSK tests should listen on loopback addresses only
  • 8f5f8f3: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
  • 1dcecb3: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile
  • ... and 42 more: https://git.openjdk.org/jdk17u-dev/compare/7d828586292dea718bb314a9b81249f6440efaf1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport ad5656f7fa53e7d380dbadc204501c3c7f2e822a 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 10, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2024

Webrevs

@sendaoYan
Copy link
Member Author

sendaoYan commented Sep 10, 2024

The GHA report a failure which I have created a issue JDK-8339844 to record that. I think this failure is unreleated to this PR.

/approval request Clean backport to fix the test bug, test fix only, no risk.

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@sendaoYan
8338748: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 10, 2024
@mrserb
Copy link
Member

mrserb commented Sep 23, 2024

Is it ready for integration?

@sendaoYan
Copy link
Member Author

Is it ready for integration?

Sorry, I miss that some have approval this PR.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@sendaoYan
Your change (at version dc5892f) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Sep 24, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit cf0fea9.
Since your change was applied there have been 52 commits pushed to the master branch:

  • 22bcb90: 8338402: GHA: some of bundles may not get removed
  • 20bd36c: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 5b94895: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion
  • 4f32fca: 8332777: Update JCStress test suite
  • 92c2465: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
  • 08b9698: 8330621: Make 5 compiler tests use ProcessTools.executeProcess
  • 9def563: 8328957: Update PKCS11Test.java to not use hardcoded path
  • f75765a: 8326898: NSK tests should listen on loopback addresses only
  • 8f5f8f3: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
  • 1dcecb3: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile
  • ... and 42 more: https://git.openjdk.org/jdk17u-dev/compare/7d828586292dea718bb314a9b81249f6440efaf1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@mrserb @sendaoYan Pushed as commit cf0fea9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants