Skip to content

8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. #2866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Sep 12, 2024

I backport this for parity with 17.0.14-oracle.
test/jdk/ProblemList.txt
not edit as it's not exist.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8296972 needs maintainer approval

Warning

 ⚠️ Found trailing period in issue title for 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.

Issue

  • JDK-8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2866/head:pull/2866
$ git checkout pull/2866

Update a local copy of the PR:
$ git checkout pull/2866
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2866

View PR using the GUI difftool:
$ git pr show -t 2866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2866.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected.

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 7161e29: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • 81b2c8d: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable
  • 6f99109: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
  • 3248a61: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
  • 51395cf: 8326611: Clean up vmTestbase/nsk/stress/stack tests
  • 81ad499: 8294726: Update URLs in minefield tests
  • 98586bb: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
  • d92d633: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
  • 91849bf: Merge
  • f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/7d828586292dea718bb314a9b81249f6440efaf1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f0c2f098150335fce736708354d58bae383cc4a1 8296972: [macos13] java/awt/Frame/MaximizedToIconified/MaximizedToIconified.java: getExtendedState() != 6 as expected. Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@GoeLin
Copy link
Member

GoeLin commented Sep 12, 2024

GHA failure: Well known ClhsdbFindPC issue, unrelated.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 13, 2024
@luchenlin
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

Going to push as commit a5d9f49.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 7161e29: 8332825: ubsan: guardedMemory.cpp:35:11: runtime error: null pointer passed as argument 2, which is declared to never be null
  • 81b2c8d: 8286160: (fs) Files.exists returns unexpected results with C:\pagefile.sys because it's not readable
  • 6f99109: 8331405: Shenandoah: Optimize ShenandoahLock with TTAS
  • 3248a61: 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap
  • 51395cf: 8326611: Clean up vmTestbase/nsk/stress/stack tests
  • 81ad499: 8294726: Update URLs in minefield tests
  • 98586bb: 8331626: unsafe.cpp:162:38: runtime error in index_oop_from_field_offset_long - applying non-zero offset 4563897424 to null pointer
  • d92d633: 8332720: ubsan: instanceKlass.cpp:3550:76: runtime error: member call on null pointer of type 'struct Array'
  • 91849bf: Merge
  • f95f7f4: 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux)
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/7d828586292dea718bb314a9b81249f6440efaf1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2024
@openjdk openjdk bot closed this Sep 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2024
@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@luchenlin Pushed as commit a5d9f49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bourgesl
Copy link
Contributor

@prrace I blame this change that is causing now more deadlocks in jdk21...

Who in client libs reviewed this change?
None...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants