Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278794: Infinite loop in DeflaterOutputStream.finish() #287

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 28, 2022

Backport of JDK-8278794
(Clean except Copyright year update.)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278794: Infinite loop in DeflaterOutputStream.finish()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/287/head:pull/287
$ git checkout pull/287

Update a local copy of the PR:
$ git checkout pull/287
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/287/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 287

View PR using the GUI difftool:
$ git pr show -t 287

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/287.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 8278794: Infinite loop in DeflaterOutputStream.finish() Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/clean

@openjdk openjdk bot added the clean label Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@TheRealMDoerr This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278794: Infinite loop in DeflaterOutputStream.finish()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit 66c3529.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 92bbdde: 8281771: Crash in java_lang_invoke_MethodType::print_signature
  • b16d037: 8270797: ShortECDSA.java test is not complete

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 29, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8278794_zip_DeflaterOutputStream branch March 29, 2022 09:25
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@TheRealMDoerr Pushed as commit 66c3529.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant