Skip to content

8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 29, 2022

A clean backport to fix a memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/288/head:pull/288
$ git checkout pull/288

Update a local copy of the PR:
$ git checkout pull/288
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/288/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 288

View PR using the GUI difftool:
$ git pr show -t 288

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/288.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5df2a057707eb65148f96710bd57d8dd8d85d1ed 8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig() Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8282628: Potential memory leak in sun.font.FontConfigManager.getFontConfig()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2022

Going to push as commit ac41711.
Since your change was applied there have been 43 commits pushed to the master branch:

  • ab2f61e: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 06c955a: 8283249: CompressedClassPointers.java fails on ppc with 'Narrow klass shift: 0' missing
  • 25f2a52: 8281450: Remove unnecessary operator new and delete from ObjectMonitor
  • 1007ded: 8280941: os::print_memory_mappings() prints segment preceeding the inclusion range
  • 0bb751b: 8280004: DCmdArgument::parse_value() should handle NULL input
  • 2875e18: 8273142: Remove dependancy of TestHttpServer, HttpTransaction, HttpCallback from open/test/jdk/sun/net/www/protocol/http/ tests
  • 6976bb4: 8256368: Avoid repeated upcalls into Java to re-resolve MH/VH linkers/invokers
  • 2c79c33: 8282590: C2: assert(addp->is_AddP() && addp->outcnt() > 0) failed: Don't process dead nodes
  • 2aa1fe0: 8283641: Large value for CompileThresholdScaling causes assert
  • b9089e7: 8283451: C2: assert(_base == Long) failed: Not a Long
  • ... and 33 more: https://git.openjdk.java.net/jdk17u-dev/compare/86ac4ab1d6aa72f75ecaa3d9d842d971e59a9a8b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2022
@openjdk openjdk bot closed this Apr 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 3, 2022
@openjdk
Copy link

openjdk bot commented Apr 3, 2022

@zhengyu123 Pushed as commit ac41711.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant