Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332724: x86 MacroAssembler may over-align code #2880

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 13, 2024

I backport this for parity with 17.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332724 needs maintainer approval

Issue

  • JDK-8332724: x86 MacroAssembler may over-align code (Bug - P5 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2880/head:pull/2880
$ git checkout pull/2880

Update a local copy of the PR:
$ git checkout pull/2880
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2880/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2880

View PR using the GUI difftool:
$ git pr show -t 2880

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2880.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332724: x86 MacroAssembler may over-align code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 08d51003d142e89b9d2f66187a4ea50e12b94fbb 8332724: x86 MacroAssembler may over-align code Sep 13, 2024
@openjdk
Copy link

openjdk bot commented Sep 13, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 13, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 13, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 15, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 17, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 17, 2024

Going to push as commit f7dff46.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 5a6a425: 8321163: [test] OutputAnalyzer.getExitValue() unnecessarily logs even when process has already completed
  • d61861b: 8317042: G1: Make TestG1ConcMarkStepDurationMillis use createTestJvm
  • fda6239: 8316446: 4 sun/management/jdp tests ignore VM flags
  • 5549655: 8314829: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java ignores vm flags
  • 17bf393: 8315988: Parallel: Make TestAggressiveHeap use createTestJvm
  • 5b10cd1: 8314831: NMT tests ignore vm flags
  • e4590bf: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags
  • 65a1215: 8314824: Fix serviceability/jvmti/8036666/GetObjectLockCount.java to use vm flags
  • 604e92d: 8282578: AIOOBE in javax.sound.sampled.Clip
  • e336d04: 8294193: Files.createDirectories throws FileAlreadyExistsException for a symbolic link whose target is an existing directory
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/7161e295db67ebdd901ac3fca4c1337dc602e944...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 17, 2024
@openjdk openjdk bot closed this Sep 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2024
@openjdk
Copy link

openjdk bot commented Sep 17, 2024

@GoeLin Pushed as commit f7dff46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant