Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334567: [test] runtime/os/TestTracePageSizes move ppc handling #2905

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 20, 2024


Progress

  • Change must not contain extraneous whitespace
  • JDK-8334567 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8334567: [test] runtime/os/TestTracePageSizes move ppc handling (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2905/head:pull/2905
$ git checkout pull/2905

Update a local copy of the PR:
$ git checkout pull/2905
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2905/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2905

View PR using the GUI difftool:
$ git pr show -t 2905

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2905.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334567: [test] runtime/os/TestTracePageSizes move ppc handling

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 4f32fca: 8332777: Update JCStress test suite
  • 92c2465: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
  • 08b9698: 8330621: Make 5 compiler tests use ProcessTools.executeProcess
  • 9def563: 8328957: Update PKCS11Test.java to not use hardcoded path
  • f75765a: 8326898: NSK tests should listen on loopback addresses only
  • 8f5f8f3: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
  • 1dcecb3: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile
  • d7d492b: 8296787: Unify debug printing format of X.509 cert serial numbers
  • 2ca2c2c: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList
  • 4120fcc: 8272746: ZipFile can't open big file (NegativeArraySizeException)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 6a5cb0b2c49cb390ce8b87fd977ee79572df90fc 8334567: [test] runtime/os/TestTracePageSizes move ppc handling Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean approval rfr Pull request is ready for review labels Sep 20, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 23, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

Going to push as commit 20bd36c.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 5b94895: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion
  • 4f32fca: 8332777: Update JCStress test suite
  • 92c2465: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
  • 08b9698: 8330621: Make 5 compiler tests use ProcessTools.executeProcess
  • 9def563: 8328957: Update PKCS11Test.java to not use hardcoded path
  • f75765a: 8326898: NSK tests should listen on loopback addresses only
  • 8f5f8f3: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
  • 1dcecb3: 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile
  • d7d492b: 8296787: Unify debug printing format of X.509 cert serial numbers
  • 2ca2c2c: 8338109: java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java duplicate in ProblemList
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/f18cde4e795988dc22b00fd66713c96185c67275...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2024
@openjdk openjdk bot closed this Sep 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@MBaesken Pushed as commit 20bd36c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant