Skip to content

8335530: Java file extension missing in AuthenticatorTest #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 23, 2024

I backport this for parity with 17.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335530 needs maintainer approval

Issue

  • JDK-8335530: Java file extension missing in AuthenticatorTest (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2908/head:pull/2908
$ git checkout pull/2908

Update a local copy of the PR:
$ git checkout pull/2908
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2908/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2908

View PR using the GUI difftool:
$ git pr show -t 2908

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2908.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335530: Java file extension missing in AuthenticatorTest

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ac5ef4b: 8295859: Update Manual Test Groups
  • cf0fea9: 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813
  • 22bcb90: 8338402: GHA: some of bundles may not get removed
  • 20bd36c: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 5b94895: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a537e87d2d2c6bff63f63bb436e3e919740221ce 8335530: Java file extension missing in AuthenticatorTest Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 23, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 24, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 24, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit 9c36bb9.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 01740fb: 8284874: Add comment to ProcessHandle/OnExitTest to describe zombie problem
  • ac5ef4b: 8295859: Update Manual Test Groups
  • cf0fea9: 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813
  • 22bcb90: 8338402: GHA: some of bundles may not get removed
  • 20bd36c: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • 5b94895: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@GoeLin Pushed as commit 9c36bb9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant