Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 #291

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 29, 2022

Clean backport of JDK-8273169
on top of JDK-8271302.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/291/head:pull/291
$ git checkout pull/291

Update a local copy of the PR:
$ git checkout pull/291
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 291

View PR using the GUI difftool:
$ git pr show -t 291

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/291.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/290 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 683e30db79789ee44b3cc0b44c085de4615bca7b 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302 Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

@TheRealMDoerr TheRealMDoerr mentioned this pull request Mar 29, 2022
2 tasks
@openjdk openjdk bot removed the clean label Mar 30, 2022
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/290 to master March 30, 2022 09:17
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout TheRealMDoerr-backport-fecefb85
git fetch https://git.openjdk.java.net/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the clean label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 30, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

Going to push as commit d89ad1f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 30, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8273169_NegativeArraySize branch March 30, 2022 09:22
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@TheRealMDoerr Pushed as commit d89ad1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant