Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272358: Some tests may fail when executed with other locales than the US #292

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 29, 2022

Clean backport of JDK-8272358


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272358: Some tests may fail when executed with other locales than the US

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/292/head:pull/292
$ git checkout pull/292

Update a local copy of the PR:
$ git checkout pull/292
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 292

View PR using the GUI difftool:
$ git pr show -t 292

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/292.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 29, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 29e552c03a2825f9526330072668a1d63ac68fd4 8272358: Some tests may fail when executed with other locales than the US Mar 29, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 29, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272358: Some tests may fail when executed with other locales than the US

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 29, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 29, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Mar 30, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2022

Going to push as commit 2f39462.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a9c2a50: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 0200d64: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 373526a: 8279219: [REDO] C2 crash when allocating array of size too large
  • 6eaf579: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
  • 9068185: 8283350: (tz) Update Timezone Data to 2022a
  • b46fabf: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • d89ad1f: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • ef42dbb: 8271302: Regex Test Refresh

Your commit was automatically rebased without conflicts.

1 similar comment
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2022

Going to push as commit 2f39462.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a9c2a50: 8277055: Assert "missing inlining msg" with -XX:+PrintIntrinsics
  • 0200d64: 8264605: vmTestbase/nsk/jvmti/SuspendThread/suspendthrd003/TestDescription.java failed with "agent_tools.cpp, 471: (foundThread = (jthread) jni_env->NewGlobalRef(foundThread)) != NULL"
  • 373526a: 8279219: [REDO] C2 crash when allocating array of size too large
  • 6eaf579: 8281544: assert(VM_Version::supports_avx512bw()) failed for Tests jdk/incubator/vector/
  • 9068185: 8283350: (tz) Update Timezone Data to 2022a
  • b46fabf: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • d89ad1f: 8273169: java/util/regex/NegativeArraySize.java failed after JDK-8271302
  • ef42dbb: 8271302: Regex Test Refresh

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 30, 2022
@openjdk openjdk bot closed this Mar 30, 2022
@openjdk openjdk bot removed ready rfr labels Mar 30, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 30, 2022

@TheRealMDoerr Pushed as commit 2f39462.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant