Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN #2923

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 30, 2024

A clean backport to improve hs_err file.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8271003 needs maintainer approval

Issue

  • JDK-8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2923/head:pull/2923
$ git checkout pull/2923

Update a local copy of the PR:
$ git checkout pull/2923
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2923

View PR using the GUI difftool:
$ git pr show -t 2923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2923.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • b434458: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely
  • 049df06: 8340657: [PPC64] SA determines wrong unextendedSP
  • 2d963ac: 8316581: Improve performance of Symbol::print_value_on()
  • e7439b7: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
  • e5b26f5: Merge
  • 1e20c7c: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 963123a: 8341057: Add 2 SSL.com TLS roots
  • 1928a36: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • a29f5fb: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
  • 1c32d3e: 8324841: PKCS11 tests still skip execution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 3435d299f76ada66e7b7cb42d9f0265cf99a30ca 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN Sep 30, 2024
@openjdk
Copy link

openjdk bot commented Sep 30, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 30, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 30, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 30, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 2, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2024

Going to push as commit 538e17a.
Since your change was applied there have been 10 commits pushed to the master branch:

  • b434458: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely
  • 049df06: 8340657: [PPC64] SA determines wrong unextendedSP
  • 2d963ac: 8316581: Improve performance of Symbol::print_value_on()
  • e7439b7: 8340230: Tests crash: assert(is_in_encoding_range || k->is_interface() || k->is_abstract()) failed: sanity
  • e5b26f5: Merge
  • 1e20c7c: 8341059: Change Entrust TLS distrust date to November 12, 2024
  • 963123a: 8341057: Add 2 SSL.com TLS roots
  • 1928a36: 8331391: Enhance the keytool code by invoking the buildTrustedCerts method for essential options
  • a29f5fb: 8334562: Automate com/sun/security/auth/callback/TextCallbackHandler/Default.java test
  • 1c32d3e: 8324841: PKCS11 tests still skip execution

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2024
@openjdk openjdk bot closed this Oct 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2024
@openjdk
Copy link

openjdk bot commented Oct 5, 2024

@GoeLin Pushed as commit 538e17a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant