Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests #2931

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 3, 2024

I backport this to improve testing in 17 and simplify further backports.

It's not a clean backport:

test/hotspot/jtreg/gc/g1/TestVerificationInConcurrentCycle.java
Skipped. Was only added by 8289740: Add verification testing during all concurrent phases in G1
which can not be backported.

test/hotspot/jtreg/gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java
Resolved. "8298073: gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java causes test task timeout on macosx" was already backported.
Flag was already removed.

test/hotspot/jtreg/gc/metaspace/TestPerfCountersAndMemoryPools.java
Resolved. Changes of "8284161: Implementation of Virtual Threads (Preview)" not in 17.

I include follow up https://bugs.openjdk.org/browse/JDK-8290269


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8290269 needs maintainer approval
  • JDK-8290023 needs maintainer approval

Issues

  • JDK-8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests (Enhancement - P4 - Approved)
  • JDK-8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2931/head:pull/2931
$ git checkout pull/2931

Update a local copy of the PR:
$ git checkout pull/2931
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2931

View PR using the GUI difftool:
$ git pr show -t 2931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2931.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b434458: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2583feb21bf5419afc3c1953d964cf89d65fe8a2 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 3, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 3, 2024

/issue JDK-8290269

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@GoeLin
Adding additional issue to issue list: 8290269: gc/shenandoah/TestVerifyJCStress.java fails due to invalid tag: required after JDK-8290023.

@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 4, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2024

Going to push as commit 7d0a5c7.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 594ce95: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
  • 9661c8b: 8283222: improve diagnosability of runtime/8176717/TestInheritFD.java timeouts
  • deefb60: 8281379: Assign package declarations to all jtreg test cases under gc
  • 23a79be: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
  • 6c5bac0: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
  • 538e17a: 8271003: hs_err improvement: handle CLASSPATH env setting longer than O_BUFLEN
  • b434458: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2024
@openjdk openjdk bot closed this Oct 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 5, 2024
@openjdk
Copy link

openjdk bot commented Oct 5, 2024

@GoeLin Pushed as commit 7d0a5c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8289740 branch October 5, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants