Skip to content

8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 4, 2024

I bacvkport this to improve testing in 17.

I had to resolve both ProblemLists and the Copyright in JShellHeapDumpTest.
Probably recognized clean.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8307408 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2938/head:pull/2938
$ git checkout pull/2938

Update a local copy of the PR:
$ git checkout pull/2938
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2938/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2938

View PR using the GUI difftool:
$ git pr show -t 2938

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2938.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b434458: 8340418: GHA: MacOS AArch64 bundles can be removed prematurely

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 87b08b6e0192d88025c2275c7dd2c4bdecda58e8 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 4, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 5, 2024

GHA failures: Error: Unable to download artifact(s) Unrelated.

@openjdk openjdk bot added the clean label Oct 5, 2024
@openjdk
Copy link

openjdk bot commented Oct 5, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 5, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 5, 2024

Going to push as commit 74545e2.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 44ca605: 8306015: Update sun.security.ssl TLS tests to use SSLContextTemplate or SSLEngineTemplate
  • 17f9b8c: 8303697: ProcessTools doesn't print last line of process output
  • 3cfa6a4: 8295239: Refactor java/util/Formatter/Basic script into a Java native test launcher
  • e45b649: 8293061: Combine CDSOptions and AppCDSOptions test utility classes
  • 7d0a5c7: 8290023: Remove use of IgnoreUnrecognizedVMOptions in gc tests
  • 594ce95: 8288976: classfile parser 'wrong name' error message has the names the wrong way around
  • 9661c8b: 8283222: improve diagnosability of runtime/8176717/TestInheritFD.java timeouts
  • deefb60: 8281379: Assign package declarations to all jtreg test cases under gc
  • 23a79be: 8271825: mark hotspot runtime/LoadClass tests which ignore external VM flags
  • 6c5bac0: 8271821: mark hotspot runtime/MinimalVM tests which ignore external VM flags
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/049df066179dba5a1ccaee64ec56b916d8b81ff1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 5, 2024
@openjdk openjdk bot closed this Oct 5, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 5, 2024
@GoeLin GoeLin deleted the goetz_backport_8307408 branch October 5, 2024 17:09
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 5, 2024
@openjdk
Copy link

openjdk bot commented Oct 5, 2024

@GoeLin Pushed as commit 74545e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant