Skip to content

8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 6, 2024

Hi all,

This pull request contains a backport of commit 977b8c4e from the openjdk/jdk repository. This backport fix test failure of Error: VM option 'ErrorHandlerTest' is develop and is available only in debug version of VM.

The commit being backported was authored by Jie Fu on 4 Aug 2021 and was reviewed by Thomas Stuefe.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8271836 needs maintainer approval

Issue

  • JDK-8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2942/head:pull/2942
$ git checkout pull/2942

Update a local copy of the PR:
$ git checkout pull/2942
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2942/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2942

View PR using the GUI difftool:
$ git pr show -t 2942

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2942.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 6, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 977b8c4e16b02421de8bf78dc60a3866ce25fc1f 8271836: runtime/ErrorHandling/ClassPathEnvVar.java fails with release VMs Oct 6, 2024
@openjdk
Copy link

openjdk bot commented Oct 6, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 6, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2024
@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix test bug, trivial fix, no risk.

@openjdk
Copy link

openjdk bot commented Oct 6, 2024

@sendaoYan
8271836: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 6, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 7, 2024
@sendaoYan
Copy link
Member Author

Thanks for the approval.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 7, 2024
@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@sendaoYan
Your change (at version 0a160f1) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 7, 2024

Thanks for fixing this!
/sponsor

@openjdk
Copy link

openjdk bot commented Oct 7, 2024

Going to push as commit 43e37bb.
Since your change was applied there have been 2 commits pushed to the master branch:

  • bbe81e9: 8317347: Parallel: Make TestInitialTenuringThreshold use createTestJvm
  • f56f7d7: 8316447: 8 sun/management/jmxremote tests ignore VM flags

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 7, 2024
@openjdk openjdk bot closed this Oct 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 7, 2024
@openjdk
Copy link

openjdk bot commented Oct 7, 2024

@GoeLin @sendaoYan Pushed as commit 43e37bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants