Skip to content

8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 9, 2024

I'd like to fix this issue in 17.

I had to resolve a #include in src/hotspot/share/jfr/jni/jfrJavaSupport.cpp. Probably clean annyways.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8280131 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing

Issue

  • JDK-8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2956/head:pull/2956
$ git checkout pull/2956

Update a local copy of the PR:
$ git checkout pull/2956
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2956

View PR using the GUI difftool:
$ git pr show -t 2956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2956.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 96dc210: 8313878: Exclude two compiler/rtm/locking tests on ppc64le

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a345df20d0a85b90e6703fba5582cacc5ba38a6d 8280131: jcmd reports "Module jdk.jfr not found." when "jdk.management.jfr" is missing Oct 9, 2024
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 9, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2024

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8280131 branch from 965901e to e6b2a20 Compare October 9, 2024 08:15
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Oct 9, 2024
@openjdk
Copy link

openjdk bot commented Oct 9, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 11, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Oct 14, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

Going to push as commit aa9c49f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fa003ff: 8289184: runtime/ClassUnload/DictionaryDependsTest.java failed with "Test failed: should be unloaded"
  • 96dc210: 8313878: Exclude two compiler/rtm/locking tests on ppc64le

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 14, 2024
@openjdk openjdk bot closed this Oct 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@GoeLin Pushed as commit aa9c49f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8280131 branch October 14, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant