8195675: Call to insertText with single character from custom Input Method ignored

[srl295]

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8195675 needs maintainer approval

Issue

• JDK-8195675: Call to insertText with single character from custom Input Method ignored (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2971/head:pull/2971
$ git checkout pull/2971

Update a local copy of the PR:
$ git checkout pull/2971
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2971

View PR using the GUI difftool:
$ git pr show -t 2971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2971.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back srl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@srl295 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8195675: Call to insertText with single character from custom Input Method ignored

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

• 00fa4df: 8340466: Add description for PassFailJFrame constructors
• 51aec1a: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
• 0881378: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
• 7caf756: 8340365: Position the first window of a window list
• bd4c65d: 8340461: Amend description for logArea
• 17f35ba: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
• 5e3c5d9: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
• 856b483: 8340306: Add border around instructions in PassFailJFrame
• 256a475: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
• eea619e: 8340210: Add positionTestUI() to PassFailJFrame.Builder
• ... and 34 more: https://git.openjdk.org/jdk17u-dev/compare/676e0491fb41d2f6daf4a29eff54f43d18f5a2ce...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[srl295]

/approval request java.awt components did not work properly on macOS with custom input methods, the net effect is that minority language keyboards did not work properly with Java. Low risk, the fix handles this situation similarly to how Apple's own 'kotoeri' input method was handled on a long term basis, so it is a well-worn path. Patch should apply cleanly and was code reviewed

[openjdk]

⚠️ @srl295 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@srl295
8195675: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (2b949bde)

[srl295]

Checked (see upstream issue)

[srl295]

/integrate

[openjdk]

Going to push as commit 9ae66af.
Since your change was applied there have been 45 commits pushed to the master branch:

• 2a9bd22: 8342578: GHA: RISC-V: Bootstrap using Debian snapshot is still failing
• 00fa4df: 8340466: Add description for PassFailJFrame constructors
• 51aec1a: 8340899: Remove wildcard bound in PositionWindows.positionTestWindows
• 0881378: 8340684: Reading from an input stream backed by a closed ZipFile has no test coverage
• 7caf756: 8340365: Position the first window of a window list
• bd4c65d: 8340461: Amend description for logArea
• 17f35ba: 8340308: PassFailJFrame: Make rows default to number of lines in instructions
• 5e3c5d9: 8339787: Add some additional diagnostic output to java/net/ipv6tests/UdpTest.java
• 856b483: 8340306: Add border around instructions in PassFailJFrame
• 256a475: 8338759: Add extra diagnostic to java/net/InetAddress/ptr/Lookup.java
• ... and 35 more: https://git.openjdk.org/jdk17u-dev/compare/676e0491fb41d2f6daf4a29eff54f43d18f5a2ce...master

Your commit was automatically rebased without conflicts.

[openjdk]

@srl295 Pushed as commit 9ae66af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.