Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8325610: CTW: Add StressIncrementalInlining to stress options #2976

Closed

Conversation

satyenme
Copy link

@satyenme satyenme commented Oct 18, 2024

Backporting JDK-8325610: CTW: Add StressIncrementalInlining to stress options. Adds -XX:+StressIncrementalInlining omitted arg to CTW test. In JDK17, args are passed in slightly differently, so backport isn't clean. Ran GHA Sanity Checks and local Tier 1 and Tier 2 tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8325610 needs maintainer approval

Issue

  • JDK-8325610: CTW: Add StressIncrementalInlining to stress options (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2976/head:pull/2976
$ git checkout pull/2976

Update a local copy of the PR:
$ git checkout pull/2976
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2976

View PR using the GUI difftool:
$ git pr show -t 2976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2976.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8325610: CTW: Add StressIncrementalInlining to stress options

Reviewed-by: ysr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

  • 6a3c646: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
  • 9000e17: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • 593d9d6: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • 676e049: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
  • 62e6c68: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent
  • 9b15f9f: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
  • fb8d7fc: 8340632: ProblemList java/nio/channels/DatagramChannel/ for Macos
  • b0e3275: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • cdd2ef2: Merge
  • eed263c: 8341673: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.13
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/b801d407e3b174d257ace832bb2301ab3a6162f3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@ysramakrishna) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 5bf859c8e9bd54cfd254a1485509a7dfa12d02af 8325610: CTW: Add StressIncrementalInlining to stress options Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

/approval request for backport. Adding missing flag to tests, doesn't impact functionality. Tested with tier1, tier2, and GHA tests. Risk is low.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@satyenme
8325610: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 18, 2024
@satyenme
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

@satyenme
Your change (at version 6a91cfd) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 21, 2024

Going to push as commit b47abe8.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 6a3c646: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java
  • 9000e17: 8332866: Crash in ImageIO JPEG decoding when MEM_STATS in enabled
  • 593d9d6: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
  • 676e049: 8339731: java.desktop/share/classes/javax/swing/text/html/default.css typo in margin settings
  • 62e6c68: 8339591: Mark jdk/jshell/ExceptionMessageTest.java intermittent
  • 9b15f9f: 8341146: RISC-V: Unnecessary fences used for load-acquire in template interpreter
  • fb8d7fc: 8340632: ProblemList java/nio/channels/DatagramChannel/ for Macos
  • b0e3275: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
  • cdd2ef2: Merge
  • eed263c: 8341673: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.13
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/b801d407e3b174d257ace832bb2301ab3a6162f3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2024
@openjdk openjdk bot closed this Oct 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 21, 2024
@openjdk
Copy link

openjdk bot commented Oct 21, 2024

@phohensee @satyenme Pushed as commit b47abe8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants