Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8328242: Add a log area to the PassFailJFrame #2982

Closed
wants to merge 1 commit into from

Conversation

toshiogata
Copy link
Contributor

@toshiogata toshiogata commented Oct 22, 2024

Hi all,

I would like to backport this patch to improve test maintainability for manual tests. The patch is clean.
Testing: manually checked some tests using PassFailJFrame, and confirmed that they work in the same way.

Thank you.


Progress

  • JDK-8328242 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8328242: Add a log area to the PassFailJFrame (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2982/head:pull/2982
$ git checkout pull/2982

Update a local copy of the PR:
$ git checkout pull/2982
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2982

View PR using the GUI difftool:
$ git pr show -t 2982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2982.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@toshiogata This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8328242: Add a log area to the PassFailJFrame

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • a6b9bfe: 8321543: Update NSS to version 3.96
  • a236389: 8328402: Implement pausing functionality for the PassFailJFrame
  • 24e2c8a: 8315097: Rename createJavaProcessBuilder
  • 48f0fa3: 8341806: Gcc version detection failure on Alinux3
  • 94eaaa8: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • b6685aa: 8341997: Tests create files in src tree instead of scratch dir
  • 56c03a4: 8273914: Indy string concat changes order of operations
  • 3d53c65: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • b47abe8: 8325610: CTW: Add StressIncrementalInlining to stress options
  • 6a3c646: 8325762: Use PassFailJFrame.Builder.splitUI() in PrintLatinCJKTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 9bc1b065db238b7c9d0562f9bd55d2f338c6ff3d 8328242: Add a log area to the PassFailJFrame Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

⚠️ @toshiogata This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 22, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 22, 2024

Webrevs

@toshiogata
Copy link
Contributor Author

/approval request I would like to backport this patch for test maintainability. The patch applies cleanly. The risk is low as this only touches tests. Testing: some manual tests using PassFailJFrame.

@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@toshiogata
8328242: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 22, 2024
@toshiogata
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@toshiogata
Your change (at version a98477c) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 24, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 24, 2024

Going to push as commit 4fea31e.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 3146710: 8323562: SaslInputStream.read() may return wrong value
  • 3660c07: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
  • a6b9bfe: 8321543: Update NSS to version 3.96
  • a236389: 8328402: Implement pausing functionality for the PassFailJFrame
  • 24e2c8a: 8315097: Rename createJavaProcessBuilder
  • 48f0fa3: 8341806: Gcc version detection failure on Alinux3
  • 94eaaa8: 8341688: Aarch64: Generate comments in -XX:+PrintInterpreter to link to source code
  • b6685aa: 8341997: Tests create files in src tree instead of scratch dir
  • 56c03a4: 8273914: Indy string concat changes order of operations
  • 3d53c65: 8309109: AArch64: [TESTBUG] compiler/intrinsics/sha/cli/TestUseSHA3IntrinsicsOptionOnSupportedCPU.java fails on Neoverse N2 and V1
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/9000e17a95027054353336f531ba64d4f5c80d7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 24, 2024
@openjdk openjdk bot closed this Oct 24, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 24, 2024
@openjdk
Copy link

openjdk bot commented Oct 24, 2024

@GoeLin @toshiogata Pushed as commit 4fea31e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants